[18.0][MIG] scheduler_error_mailer by astirpe · Pull Request #3084 · OCA/server-tools

astirpe · 2024-10-17T07:25:23Z

No description provided.

StefanRijnhart · 2025-02-07T09:43:00Z

/ocabot migration scheduler_error_mailer

StefanRijnhart

Tests are fixed in #3190. Please rebase once that one is merged.

astirpe · 2025-02-07T11:16:02Z

@StefanRijnhart I will, thank you!

astirpe · 2025-02-07T14:35:33Z

rebased

CRogos

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.
Here are some examples:

Maybe we could also improve the test and test "def _callback" instead of "def _handle_callback_exception"?

CRogos · 2025-04-10T14:13:36Z

@astirpe are you still working on this?

astirpe · 2025-04-10T15:08:45Z

@CRogos Thank you for your review! I'm very busy with projects, I could continue with this when I can find some time. Sorry

StefanRijnhart · 2025-04-16T08:10:08Z

@CRogos Is it alright for you now?

StefanRijnhart · 2025-04-16T09:09:44Z

Oh, we're getting errors because the mail template body is no longer valid due to the ir.cron datamodel changes. @astirpe would you consider taking astirpe#1?

astirpe · 2025-04-16T09:31:26Z

Thank you @StefanRijnhart !

CRogos

Can you squash your latest changes with the Migration commit and also cleanup the commits above according to the migration guide?

CRogos · 2025-04-16T09:21:01Z

            self._handle_callback_exception(cron_name, server_action_id, e)
+
+            # Re-raise the original job exception
+            raise e


Can't we write raise without the e to reraise?

CRogos · 2025-04-16T09:48:23Z

Are you sure this is the best option?

Couldn't we just call load_data with the ir_cron_email_tpl.xml file?
https://github.com/OCA/openupgradelib/blob/37cc7eeb1383fbe7c3d5cd2666af3b73338a90cd/openupgradelib/openupgrade.py#L292

Something like this:
OCA/account-financial-reporting@8ba049e8

That would be equivalent to calling reset_template on the template, but it would reset other fields as well such as subject and recipients which are customized in our setups. Also, this bit takes care to reset the body in each language (as per code taken from reset_template).

For reference: code is based on https://github.com/odoo/odoo/blob/18.0/addons/mail/models/template_reset_mixin.py#L70-L93

StefanRijnhart · 2025-04-16T10:36:46Z

Apologies @astirpe, it turns out that in migrated databases the template_fs of the template might not be set, so here is astirpe#2. And please rebase and squash all migration commits as @CRogos suggests.

astirpe · 2025-04-16T10:49:31Z

I will do the rebase and squash, thanks!

CRogos · 2025-04-16T12:11:59Z

+    @api.model
+    def _test_scheduler_failure(self):
+        """This function is used to test and debug this module."""
+        raise UserError(_("Task failure with UID = %d.") % self._uid)


_ should also be replaced

raise UserError(self.env._("Task failure with UID = %(uid)d.", uid=self._uid))

CRogos · 2025-04-16T19:29:00Z

    def _test_scheduler_failure(self):
        """This function is used to test and debug this module."""
-        raise UserError(_("Task failure with UID = %d.") % self._uid)
+        raise UserError(_("Task failure with UID = %(uid)d."), uid=self._uid)


https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

You can replace the call to translate a string () with self.env. for getting some performance improvement in some cases. See odoo/odoo#174844.

Currently translated at 100.0% (8 of 8 strings) Translation: server-tools-15.0/server-tools-15.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-scheduler_error_mailer/es_AR/

[UPD] README.rst

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-scheduler_error_mailer/

Currently translated at 100.0% (9 of 9 strings) Translation: server-tools-16.0/server-tools-16.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-scheduler_error_mailer/es_AR/

Currently translated at 100.0% (9 of 9 strings) Translation: server-tools-16.0/server-tools-16.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-scheduler_error_mailer/es/

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-scheduler_error_mailer/

[BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-scheduler_error_mailer/

Translated using Weblate (Italian) Currently translated at 100.0% (8 of 8 strings) Translation: server-tools-17.0/server-tools-17.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-scheduler_error_mailer/it/

Currently translated at 100.0% (8 of 8 strings) Translation: server-tools-17.0/server-tools-17.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-scheduler_error_mailer/zh_CN/

Update scheduler_error_mailer/models/ir_cron.py Co-authored-by: Christopher Rogos <crogos@gmail.com> Update scheduler_error_mailer/models/ir_cron.py C#o-authored-by: Christopher Rogos <crogos@gmail.com>

…del changes [FIX] scheduler_error_mailer: migrated template might not have template_fs

astirpe · 2025-06-27T06:57:28Z

@CRogos squashed, thanks!

OCA-git-bot · 2025-06-27T07:21:51Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart · 2025-06-27T07:34:36Z

/ocabot merge nobump

OCA-git-bot · 2025-06-27T07:34:43Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3084-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2025-06-27T07:41:37Z

Congratulations, your PR was merged at 4d92829. Thanks a lot for contributing to OCA. ❤️

CasVissers-360ERP reviewed Nov 26, 2024

View reviewed changes

Comment thread scheduler_error_mailer/models/ir_cron.py Outdated

astirpe force-pushed the 18_mig_scheduler_error_mailer branch 4 times, most recently from d3b6403 to 077b944 Compare November 26, 2024 11:54

astirpe marked this pull request as ready for review November 26, 2024 11:59

StefanRijnhart mentioned this pull request Feb 7, 2025

18.0 mig scheduler error mailer #3192

Closed

OCA-git-bot added this to the 18.0 milestone Feb 7, 2025

OCA-git-bot mentioned this pull request Feb 7, 2025

Migration to version 18.0 #3047

Open

42 tasks

StefanRijnhart approved these changes Feb 7, 2025

View reviewed changes

astirpe force-pushed the 18_mig_scheduler_error_mailer branch from 077b944 to fb57bb5 Compare February 7, 2025 14:30

CRogos suggested changes Mar 24, 2025

View reviewed changes

Comment thread scheduler_error_mailer/models/ir_cron.py

CRogos reviewed Mar 24, 2025

View reviewed changes

Comment thread scheduler_error_mailer/tests/test_scheduler_error_mailer.py Outdated

astirpe force-pushed the 18_mig_scheduler_error_mailer branch 2 times, most recently from 4cc7a69 to 33debe6 Compare April 12, 2025 18:30

astirpe requested a review from CasVissers-360ERP April 16, 2025 08:41

CRogos suggested changes Apr 16, 2025

View reviewed changes

CRogos reviewed Apr 16, 2025

View reviewed changes

astirpe force-pushed the 18_mig_scheduler_error_mailer branch from 2eab569 to a743176 Compare April 16, 2025 18:12

CRogos reviewed Apr 16, 2025

View reviewed changes

ibuioli and others added 17 commits June 27, 2025 08:53

[MIG] scheduler_error_mailer

6bee71a

[IMP] set default template

80f37eb

[ADD] tests

b977f2c

[UPD] Update scheduler_error_mailer.pot

fbe5022

[UPD] README.rst

Translated using Weblate (Spanish)

65f5645

Currently translated at 100.0% (9 of 9 strings) Translation: server-tools-16.0/server-tools-16.0-scheduler_error_mailer Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-scheduler_error_mailer/es/

[IMP] scheduler_error_mailer: pre-commit auto fixes

82270d7

[MIG] scheduler_error_mailer: Migration to 17.0

a80ed2b

[MIG] scheduler_error_mailer: pre-commit

f179437

[MIG] scheduler_error_mailer: migrate to V18

31d81ed

Update scheduler_error_mailer/models/ir_cron.py Co-authored-by: Christopher Rogos <crogos@gmail.com> Update scheduler_error_mailer/models/ir_cron.py C#o-authored-by: Christopher Rogos <crogos@gmail.com>

[MIG] scheduler_error_mailer: reset email template body after data mo…

d4cee9d

…del changes [FIX] scheduler_error_mailer: migrated template might not have template_fs

astirpe force-pushed the 18_mig_scheduler_error_mailer branch from 05d6184 to d4cee9d Compare June 27, 2025 06:54

CRogos approved these changes Jun 27, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 27, 2025

OCA-git-bot added the bot is merging ⏳ label Jun 27, 2025

OCA-git-bot merged commit 9e5caeb into OCA:18.0 Jun 27, 2025

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 27, 2025

Uh oh!

Uh oh!

Conversation

astirpe commented Oct 17, 2024

Uh oh!

Uh oh!

StefanRijnhart commented Feb 7, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

astirpe commented Feb 7, 2025

Uh oh!

astirpe commented Feb 7, 2025

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CRogos commented Apr 10, 2025

Uh oh!

astirpe commented Apr 10, 2025

Uh oh!

StefanRijnhart commented Apr 16, 2025

Uh oh!

StefanRijnhart commented Apr 16, 2025

Uh oh!

astirpe commented Apr 16, 2025

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

astirpe Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

CRogos Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented Apr 16, 2025

Uh oh!

astirpe commented Apr 16, 2025

Uh oh!

CRogos Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

CRogos Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

astirpe commented Jun 27, 2025

Uh oh!

OCA-git-bot commented Jun 27, 2025

Uh oh!

StefanRijnhart commented Jun 27, 2025

Uh oh!

OCA-git-bot commented Jun 27, 2025

Uh oh!

OCA-git-bot commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

StefanRijnhart Apr 16, 2025 •

edited

Loading