[18.0][MIG] autovacuum_message_attachment: Migration to 18.0 - #3158
Merged
OCA-git-bot merged 31 commits intoJan 27, 2025
Conversation
vvrossem
reviewed
Jan 16, 2025
vvrossem
left a comment
Contributor
There was a problem hiding this comment.
Some suggestions 🙇
Please squash administrative commits too 🙏
vvrossem
reviewed
Jan 16, 2025
… it is already present in other models
Currently translated at 100.0% (50 of 50 strings) Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
Selection of attachments through inheriting model can be useful if we want to purge attachments that are extended through another model. For example, shipping.label (from base_delivery_carrier_label) inherits from ir.attachment but the attachment itself is linked to the stock.picking model. By using inheriting_model defined to shipping.label and setting model_ids to stock.picking, we can safely select the attachments linked to stock.pickings that are shipping labels and avoid deleting any picking list or delivery note reports.
Currently translated at 100.0% (55 of 55 strings) Translation: server-tools-14.0/server-tools-14.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-autovacuum_message_attachment/es_AR/
But allow it only if a file pattern is set, to avoid deleting all orphan attachments are some are auto-generated by Odoo
Currently translated at 67.3% (35 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/
Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es/
Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
Currently translated at 100.0% (52 of 52 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/es_AR/
Currently translated at 100.0% (61 of 61 strings) Translation: server-tools-16.0/server-tools-16.0-autovacuum_message_attachment Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-autovacuum_message_attachment/it/
yankinmax
force-pushed
the
18.0-mig-autovacuum_message_attachment
branch
from
January 21, 2025 13:28
213e6c8 to
af7967b
Compare
vvrossem
approved these changes
Jan 21, 2025
StephaneMangin
approved these changes
Jan 21, 2025
StephaneMangin
left a comment
There was a problem hiding this comment.
Maybe it could be a good approach to increase tests when the coverage increase over time. It's less effort on the long term. But anyway LGTM
Contributor
|
This PR has the |
yankinmax
force-pushed
the
18.0-mig-autovacuum_message_attachment
branch
from
January 21, 2025 14:29
af7967b to
79ce63a
Compare
Ricardoalso
approved these changes
Jan 21, 2025
Contributor
|
/ocabot migration autovacuum_message_attachment |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at b57f114. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.