[18.0][FIX] base_cron_exclusion: remove numbercall condition from ir_cron select clause

[xaviedoanhduy]

• numbercall and doall have been removed in commit odoo/odoo@3a9949ad, but in the process of moving to version 18.0 in this PR I missed this change. [18.0][MIG] base_cron_exclusion: Migration to 18.0 #3059
• also take this opportunity to replace _ with self.env._ to improve the old PR above

[OCA-git-bot]

Hi @LoisRForgeFlow, @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!

[LoisRForgeFlow]

numbercall part is correct, thank for fixing. For the other part, could you clarify why is it better self.env._ in this case?

Thanks!

[xaviedoanhduy]

numbercall part is correct, thank for fixing. For the other part, could you clarify why is it better self.env._ in this case?

Thanks!

hi @LoisRForgeFlow, there is a quote in the Migration to 18.0 document (see: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0)

You can replace the call to translate a string () with self.env. for getting some performance improvement in some cases. See odoo/odoo#174844.

[LoisRForgeFlow]

Thanks for the pointer 👌

[LoisRForgeFlow]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3167-by-LoisRForgeFlow-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3900ffc. Thanks a lot for contributing to OCA. ❤️