[18.0][MIG] auto_backup: Migration to 18.0 by michelerusti · Pull Request #3169 · OCA/server-tools

michelerusti · 2025-01-17T10:22:27Z

No description provided.

fmdl · 2025-01-26T07:44:25Z

+                        class="oe_highlight"
+                    />
+                </header>
+                <div class="oe_title">


add:

<sheat>

fmdl · 2025-01-26T07:45:17Z

+                    >Set the scheduler to active and fill in how often you want backups generated.</li>
+                </ol>
+                </div>
+            </form>


add:

</sheet> <div class="oe_chatter"> <field name="message_follower_ids" groups="base.group_user"/> <field name="message_ids"/> </div>

thanks, added!

Should be ok now

fmdl

don't forget to update the db.backup view

Added all the new fields and sentences. This will be the template for translations.

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

- Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. - Reduce headers. This respects the upstream license choice (GPL/AGPL) but reduces verbosity. It would be ideal to have everything under AGPL though.

Bump module version to 8.0.1.0.1

* Add self.ensure_ones * Add test coverage

Fixes OCA#710

* [10.0][auto_backup] Menu entry moved * Update version in manifest

Currently translated at 58.2% (32 of 55 strings) Translation: server-tools-11.0/server-tools-11.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/

Added test coverage Added requirements.txt for pysftp Added in the roadmap the exact version of pysftp for this to work (0.2.8) Added in the roadmap the problem with list_db=False Adapted calls to message_post

Currently translated at 17.5% (14 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/

Currently translated at 26.2% (21 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Currently translated at 90.0% (72 of 80 strings) Translation: server-tools-15.0/server-tools-15.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/

Currently translated at 84.7% (72 of 85 strings) Translation: server-tools-15.0/server-tools-15.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/

Currently translated at 100.0% (85 of 85 strings) Translation: server-tools-16.0/server-tools-16.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/es/

Currently translated at 87.0% (74 of 85 strings) Translation: server-tools-16.0/server-tools-16.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/

Fixes OCA#3066

tafaRU

Thanks for the PR!
LG overall 👍 , just a nitpick.

tafaRU · 2025-02-11T11:08:55Z

@@ -180,7 +180,7 @@ def action_backup(self):
                        with rec.sftp_connection() as remote:
                            # Directory must exist


I think this comment could be removed in face of https://bitbucket.org/dundeemt/pysftp/src/1c0791759688a733a558b1a25d9ae04f52cf6a64/pysftp/__init__.py#lines-676

michelerusti · 2025-02-11T13:57:53Z

@fmdl is the PR all good now or are there more changes needed? Could you update the review please?

OCA-git-bot · 2025-02-11T17:42:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

michelerusti · 2025-02-13T09:37:02Z

@OCA/tools-maintainers this PR seems ready for the next stage. Could any of you approve it?

thomaspaulb · 2025-02-13T13:14:32Z

/ocabot migration auto_backup

/ocabot merge nobump

OCA-git-bot · 2025-02-13T13:14:39Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3169-by-thomaspaulb-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-13T13:20:26Z

Congratulations, your PR was merged at fe22456. Thanks a lot for contributing to OCA. ❤️

michelerusti force-pushed the 18.0-mig-auto_backup branch 3 times, most recently from 91e3a81 to 1e35d55 Compare January 17, 2025 15:02

michelerusti marked this pull request as ready for review January 17, 2025 15:59

michelerusti mentioned this pull request Jan 17, 2025

Migration to version 18.0 #3047

Open

42 tasks

fmdl reviewed Jan 26, 2025

View reviewed changes

fmdl suggested changes Jan 26, 2025

View reviewed changes

michelerusti force-pushed the 18.0-mig-auto_backup branch 2 times, most recently from 276413a to 0e4c741 Compare January 30, 2025 16:38

Yenthe666 and others added 20 commits February 10, 2025 16:22

Update english pot file

2331640

Added all the new fields and sentences. This will be the template for translations.

Open FTP session on the last moment possible

dff5f8f

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

FIX License type

65a7ea4

[FIX] auto_backup: bad reference to field sftp_private_key (OCA#423)

3edaf10

Bump module version to 8.0.1.0.1

[FIX] logger db_backup for pysftp (OCA#419)

9c73d95

[FIX] remove en.po that was erroneously created by transbot

6c665e4

[MIG] auto_backup: Migrate to v9

7048e28

* Add self.ensure_ones * Add test coverage

[auto_backup] FIX: failure type notification

2f9aa9a

Fixes OCA#710

[10.0][auto_backup] Menu entry moved (OCA#735)

3c97185

* [10.0][auto_backup] Menu entry moved * Update version in manifest

FIX sftp unlink path (OCA#767)

f9947e4

Fix icon Test SFTP Connection (OCA#825)

163e996

[11.0][MIG] auto_backup

0d3f3a9

[FIX] syntax error in nl.po

9f60e3f

Translated using Weblate (Dutch)

6fe7d57

Currently translated at 58.2% (32 of 55 strings) Translation: server-tools-11.0/server-tools-11.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/

[FIX] auto_backup: Fix NL translation

4aa9c30

auto_backup: allow to change the format of backup (OCA#1333)

b88fcf1

[MIG] auto_backup: Migration to 12.0

5f60872

Added test coverage Added requirements.txt for pysftp Added in the roadmap the exact version of pysftp for this to work (0.2.8) Added in the roadmap the problem with list_db=False Adapted calls to message_post

Translated using Weblate (Portuguese (Brazil))

7aebf33

Currently translated at 17.5% (14 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/

Translated using Weblate (Chinese (Simplified))

ca7a4a5

Currently translated at 26.2% (21 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

francesco-ooops and others added 9 commits February 10, 2025 16:22

Translated using Weblate (Italian)

3d939e5

Currently translated at 90.0% (72 of 80 strings) Translation: server-tools-15.0/server-tools-15.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/

Translated using Weblate (Italian)

f470050

Currently translated at 90.0% (72 of 80 strings) Translation: server-tools-15.0/server-tools-15.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/

Translated using Weblate (Italian)

d1eded7

Currently translated at 84.7% (72 of 85 strings) Translation: server-tools-15.0/server-tools-15.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/

[IMP] auto_backup: pre-commit stuff

b433ea6

[MIG] auto_backup: Migration to 16.0

f17a0e4

Translated using Weblate (Spanish)

427bef6

Currently translated at 100.0% (85 of 85 strings) Translation: server-tools-16.0/server-tools-16.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/es/

Translated using Weblate (Italian)

8d3db1b

Currently translated at 87.0% (74 of 85 strings) Translation: server-tools-16.0/server-tools-16.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/it/

[FIX] auto_backup: Don't complain on existing folder

98edb0f

Fixes OCA#3066

[IMP] auto_backup: pre-commit auto fixes

fc81f02

michelerusti force-pushed the 18.0-mig-auto_backup branch 2 times, most recently from fff6d8d to e548a73 Compare February 10, 2025 15:51

tafaRU suggested changes Feb 11, 2025

View reviewed changes

[MIG] auto_backup: Migration to 18.0

f519353

michelerusti force-pushed the 18.0-mig-auto_backup branch from e548a73 to f519353 Compare February 11, 2025 13:28

tafaRU approved these changes Feb 11, 2025

View reviewed changes

michelerusti requested a review from fmdl February 11, 2025 13:45

fmdl approved these changes Feb 11, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 11, 2025

OCA-git-bot added this to the 18.0 milestone Feb 13, 2025

OCA-git-bot added the bot is merging ⏳ label Feb 13, 2025

OCA-git-bot merged commit ae96869 into OCA:18.0 Feb 13, 2025

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 13, 2025

Navigation Menu

Uh oh!

Uh oh!

[18.0][MIG] auto_backup: Migration to 18.0 - #3169

[18.0][MIG] auto_backup: Migration to 18.0#3169
OCA-git-bot merged 49 commits into
OCA:18.0from
michelerusti:18.0-mig-auto_backup

michelerusti commented Jan 17, 2025

Uh oh!

fmdl Jan 26, 2025 •

edited

Loading

Uh oh!

fmdl Jan 26, 2025 •

edited

Loading

Uh oh!

michelerusti Jan 30, 2025

Uh oh!

fmdl left a comment

Uh oh!

tafaRU left a comment

Uh oh!

tafaRU Feb 11, 2025

Uh oh!

michelerusti commented Feb 11, 2025

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

michelerusti commented Feb 13, 2025

Uh oh!

thomaspaulb commented Feb 13, 2025

Uh oh!

OCA-git-bot commented Feb 13, 2025

Uh oh!

OCA-git-bot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		@@ -180,7 +180,7 @@ def action_backup(self):
		with rec.sftp_connection() as remote:
		# Directory must exist

Uh oh!

Uh oh!

Conversation

michelerusti commented Jan 17, 2025

Uh oh!

fmdl Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmdl Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michelerusti Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

fmdl left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU left a comment

Choose a reason for hiding this comment

Uh oh!

tafaRU Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

michelerusti commented Feb 11, 2025

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

michelerusti commented Feb 13, 2025

Uh oh!

thomaspaulb commented Feb 13, 2025

Uh oh!

OCA-git-bot commented Feb 13, 2025

Uh oh!

OCA-git-bot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

fmdl Jan 26, 2025 •

edited

Loading

fmdl Jan 26, 2025 •

edited

Loading