[18.0][MIG] Migration of module_auto_update - #3186
Conversation
fkantelberg
commented
Feb 4, 2025
- No real change was needed just a small swap from %-formatting to .format as requested by CI/ruff [UP031]
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! Can you mention in the documentation that click-odoo-update exists as an alternative (https://github.com/acsone/click-odoo-contrib) which implements the same functionality but is run as an external python tool so it is easier to integrate with other non-Odoo maintenance tools.
|
Tests are fixed in #3190. Your review there would be welcome. |
6d3c2c9 to
156dca5
Compare
|
Thank you for the review. I indeed missed the changes in the hook and it's nice to know. I added a reference to click-odoo-update. It's a nice alternative from the community but no replacement because it brings the dependencies differently from my point of view. |
Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-15.0/server-tools-15.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_auto_update/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es_AR/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es/
Currently translated at 60.0% (3 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-17.0/server-tools-17.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/
Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-17.0/server-tools-17.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/it/
Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-17.0/server-tools-17.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/zh_CN/
156dca5 to
3c05f96
Compare
StefanRijnhart
left a comment
There was a problem hiding this comment.
True, if you rely on the server action from this module it's not a replacement. Thanks for the changes.
|
Hey @StefanRijnhart is it possible to merge this one? Thanks! |
|
@Garcicasti asking for a merge is not helpful, but doing a review is! |
jmartinacu
left a comment
There was a problem hiding this comment.
Se ha revisado y probado la Pull Request y cumple con los siguientes criterios:
- Funcionamiento validado: Todas las funcionalidades implementadas o modificadas han sido verificadas y funcionan correctamente en el entorno de prueba.
- Tests exitosos: Se han ejecutado todas las pruebas automatizadas y han pasado sin errores. Además, se ha confirmado que los checks necesarios siguen ejecutándose correctamente.
- Documentación y comentarios: El código está bien documentado y, en caso necesario, se han actualizado los archivos de documentación relevantes.
|
This PR has the |
|
@StefanRijnhart Alright, my colleague @jmartinacu just reviewed and approve it. Can it be merged now that it has 2 reviews? Thanks! And BTW, communicating in a non passive-aggresive way is also helpful! |
|
@Garcicasti you are right, I should not have taken it out on you. Thanks for the review! /ocabot migration module_auto_update |
|
On my way to merge this fine PR! |
|
@fkantelberg We need to check next time if an existing migration PR already exists. I'm now seeing #3119. |
|
Congratulations, your PR was merged at e697148. Thanks a lot for contributing to OCA. ❤️ |