[18.0][MIG] sequence_python: Migration to 18.0 - #3258
Conversation
82309c6 to
0e24679
Compare
Currently translated at 100.0% (21 of 21 strings) Translation: server-tools-14.0/server-tools-14.0-sequence_python Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-sequence_python/es_AR/
Currently translated at 100.0% (18 of 18 strings) Translation: server-tools-16.0/server-tools-16.0-sequence_python Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-sequence_python/it/
0e24679 to
0862996
Compare
|
Hello, any PSM to approve and merge this PR please ? (@pedrobaeza) |
| options="{'mode': 'python'}" | ||
| placeholder="number" | ||
| attrs="{'invisible': [('use_python_code', '=', False)]}" | ||
| invisible="use_python_code == False" |
There was a problem hiding this comment.
Nitpicking : Maybe use not use_python_code instead ?
| <field | ||
| name="python_code_preview" | ||
| attrs="{'invisible': [('use_python_code', '=', False)]}" | ||
| invisible="use_python_code == False" |
There was a problem hiding this comment.
Nitpicking : Maybe use not use_python_code instead ?
| if isinstance(number_next, tuple): | ||
| number_next = number_next[0] | ||
| return { | ||
| "number": number_next[0] if isinstance(number_next, tuple) else number_next, |
There was a problem hiding this comment.
As you added :
if isinstance(number_next, tuple): number_next = number_next[0]
This gets redundant :
"number": number_next[0] if isinstance(number_next, tuple) else number_next
We may change it to :
"number": number_next,
tgaona-sbg
left a comment
There was a problem hiding this comment.
Nothing blocking, only some possible reformat options, code LGTM.
Only after two approvals have already been give by others you can ping oca/tools-maintainers team |
|
/ocabot migration sequence_python /ocabot merge nobump |
|
On my way to merge this fine PR! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at ce786c2. Thanks a lot for contributing to OCA. ❤️ |
No description provided.