Skip to content

[18.0][MIG] attachment_delete_restrict: Migration to 18.0 - #3312

Merged
OCA-git-bot merged 24 commits into
OCA:18.0from
qrtl:18.0-mig-attachment_delete_restrict
Jan 25, 2026
Merged

[18.0][MIG] attachment_delete_restrict: Migration to 18.0#3312
OCA-git-bot merged 24 commits into
OCA:18.0from
qrtl:18.0-mig-attachment_delete_restrict

Conversation

@AungKoKoLin1997

@AungKoKoLin1997 AungKoKoLin1997 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

@qrtl QT5088

yostashiro and others added 22 commits June 17, 2025 08:21
@yostashiro @AungKoKoLin1997
[ADD] attachment_delete_restrict
1b7c6b5
@Kev-Roche @AungKoKoLin1997
[IMP] attachment_delete_restrict: black, isort, prettier
b3db51c
@Kev-Roche @AungKoKoLin1997
[MIG] attachment_delete_restrict: Migration to 14.0
e34ffbe
@Kev-Roche @AungKoKoLin1997
rework module attachment_delete_restrict (to squash after review)
37b9cdd
@sebastienbeau @AungKoKoLin1997
attachment_delete_restrict: refactor test and improve restrict mode n…
197aa2f 
…aming
@sebastienbeau @AungKoKoLin1997
attachment_delete_restrict: refactor code
4d9cd25
oca-ci @AungKoKoLin1997
[UPD] Update attachment_delete_restrict.pot
90229b4
@OCA-git-bot @AungKoKoLin1997
[UPD] README.rst
7d63001
@OCA-git-bot @AungKoKoLin1997
[ADD] icon.png
5b3c742
@ibuioli @AungKoKoLin1997
Added translation using Weblate (Spanish (Argentina))
b8ba7f7
@ibuioli @AungKoKoLin1997
Translated using Weblate (Spanish (Argentina))
aa5c9d2 
Currently translated at 100.0% (37 of 37 strings)

Translation: server-tools-14.0/server-tools-14.0-attachment_delete_restrict
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-attachment_delete_restrict/es_AR/
Jon @AungKoKoLin1997
[FIX] attachment_delete_restrict: adapt to Odoo permission change
2ad9eea
@OCA-git-bot @AungKoKoLin1997
attachment_delete_restrict 14.0.1.0.1
58cc53a
@AungKoKoLin1997
[MIG] attachment_delete_restrict: Migration to 16.0
781997b
@AungKoKoLin1997
[FIX] attachment_delete_restrict
58f736c 
- Remove the display of duplicate allowed user names.
- Correct the many2many field relation
- Correct domain values and add the many2many_tags widget in views.
@AungKoKoLin1997
[IMP] attachment_delete_restrict
19d7512 
- Add _onchange_restrict_delete_attachment() to clear groups and users when restrict_delete_attachment is not set to custom or owner_custom.
@sebastienbeau @AungKoKoLin1997
attachment_delete_restrict: using sudo should by pass the restriction
283be52
oca-ci @AungKoKoLin1997
[UPD] Update attachment_delete_restrict.pot
09a465d
@OCA-git-bot @AungKoKoLin1997
[BOT] post-merge updates
a404df6
@mymage @AungKoKoLin1997
Added translation using Weblate (Italian)
a18f792
@mymage @AungKoKoLin1997
Translated using Weblate (Italian)
10c4ccf 
Currently translated at 100.0% (38 of 38 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_delete_restrict
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_delete_restrict/it/
@AungKoKoLin1997
[IMP] attachment_delete_restrict: pre-commit auto fixes
09b223e
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as draft June 17, 2025 09:38
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-attachment_delete_restrict branch from 9e29625 to 86c91bf Compare June 24, 2025 06:53
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as ready for review June 24, 2025 06:53
yostashiro
yostashiro reviewed Jun 24, 2025
View reviewed changes
Comment thread attachment_delete_restrict/tests/test_attachment_delete_restrict.py Outdated
Comment thread attachment_delete_restrict/views/res_config_setting_views.xml Outdated
Comment thread attachment_delete_restrict/tests/test_attachment_delete_restrict.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-attachment_delete_restrict branch from 86c91bf to 8df8734 Compare June 24, 2025 10:34
yostashiro
yostashiro suggested changes Jun 24, 2025
View reviewed changes
Comment thread attachment_delete_restrict/models/ir_attachment.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-attachment_delete_restrict branch from 8df8734 to 39068c8 Compare June 25, 2025 01:23
yostashiro
yostashiro approved these changes Jun 25, 2025
View reviewed changes

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.

kanda999
kanda999 reviewed Jul 2, 2025
View reviewed changes

@kanda999 kanda999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point

Comment thread attachment_delete_restrict/tests/test_attachment_delete_restrict.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 18.0-mig-attachment_delete_restrict branch from 39068c8 to 3b188a0 Compare July 2, 2025 10:28
@AungKoKoLin1997
AungKoKoLin1997 requested a review from kanda999 July 2, 2025 10:28
kanda999
kanda999 approved these changes Jul 3, 2025
View reviewed changes

@kanda999 kanda999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review.

@OCA-git-bot

OCA-git-bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Aug 15, 2025
Open
Sayaka-qrtl
Sayaka-qrtl reviewed Aug 21, 2025
View reviewed changes

@Sayaka-qrtl Sayaka-qrtl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there’s a difference between the five levels described in README.rst and what’s actually shown on the screen. Should we standardize them to use Owner + Custom as in the UI?

FrancoMaxime
FrancoMaxime approved these changes Sep 16, 2025
View reviewed changes

@FrancoMaxime FrancoMaxime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

@thomaspaulb

thomaspaulb commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

/ocabot migration attachment_delete_restrict

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 25, 2026
@OCA-git-bot

OCA-git-bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3312-by-thomaspaulb-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 25, 2026
@OCA-git-bot
Merge PR #3312 into 18.0
9dc8e90 
Signed-off-by thomaspaulb
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 25, 2026
Open
42 tasks
@OCA-git-bot

OCA-git-bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-3312-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit bbb4414 into OCA:18.0 Jan 25, 2026
6 of 7 checks passed
@OCA-git-bot

OCA-git-bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 09180fa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sayaka-qrtl Sayaka-qrtl Awaiting requested review from Sayaka-qrtl
3 more reviewers
@yostashiro yostashiro yostashiro approved these changes
@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes
@kanda999 kanda999 kanda999 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.