Skip to content

[19.0][MIG] module_change_auto_install: Migration to 19.0 - #3384

Merged
OCA-git-bot merged 36 commits into
OCA:19.0from
DynAppsNV:19.0-mig-module_change_auto_install
Jan 4, 2026
Merged

[19.0][MIG] module_change_auto_install: Migration to 19.0#3384
OCA-git-bot merged 36 commits into
OCA:19.0from
DynAppsNV:19.0-mig-module_change_auto_install

Conversation

@rven

@rven rven commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

legalsylvain and others added 30 commits September 22, 2025 13:49
Optimize validation
Add logger to apply patch
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-module_change_auto_install
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_change_auto_install/
@rven
rven marked this pull request as ready for review September 25, 2025 13:04
@rven
rven requested a review from legalsylvain September 25, 2025 13:04
@rven

rven commented Sep 26, 2025

Copy link
Copy Markdown
Contributor Author

When adding the configuration to the odoo's config file, this warning is shown

2025-09-25 14:44:14,513 556 WARNING ? odoo.tools.config: unknown option 'modules_auto_install_disabled' in the config file at /root/.odoorc, option stored as-is, without parsing

Anybody who knows how we could fix this?

@legalsylvain

Copy link
Copy Markdown
Contributor

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

@rven

rven commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

It looks like the spirit of Odoo V19, is to have a fixed quantity of option in the [options] section, defined in the core code.

Could you try to replace :

[options]
server_wide_modules = web,module_change_auto_install

modules_auto_install_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_auto_install_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

by

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

I tried several ways, but the warning pops up too soon.
Odoo refatcored it completly to show a warning on non standard options.

@legalsylvain

Copy link
Copy Markdown
Contributor

I tried several ways, but the warning pops up too soon.

Could you update the logs ?

We can wait and take a look on this similar OCA modules that will have the same problems :

@rven

rven commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

What do you mean with

Could you update the logs ?

@legalsylvain

Copy link
Copy Markdown
Contributor

What do you mean with

Could you update the logs ?

Could you put the new log, when you use [module_change_auto_install] in the odoo.cfg file ?

thanks !

@rven
rven force-pushed the 19.0-mig-module_change_auto_install branch 2 times, most recently from fe2b3c5 to 086cfb3 Compare September 30, 2025 06:31
@rven

rven commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

@legalsylvain I've managed to use the following config as you mentioned

[options]

server_wide_modules = web,module_change_auto_install

[module_change_auto_install]
modules_disabled =
       partner_autocomplete,
       iap,
       mail_bot

modules_enabled =
       web_responsive:web,
       base_technical_features,
       disable_odoo_online,
       account_usability

Can you have a look?

@rven rven mentioned this pull request Sep 30, 2025
43 tasks
@rven
rven force-pushed the 19.0-mig-module_change_auto_install branch from 086cfb3 to 494a9b7 Compare October 13, 2025 09:08
@rven

rven commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

Changes implemented after this commit of Odoo odoo/odoo@2b4b30c

OCB has not yet the latest version of Odoo.

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick overview. LGTM. code review / no test.

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Functional test.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3384-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart

Copy link
Copy Markdown
Member

/ocabot migration module_change_auto_install

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jan 4, 2026
@OCA-git-bot
OCA-git-bot merged commit 89f3790 into OCA:19.0 Jan 4, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f839547. Thanks a lot for contributing to OCA. ❤️

@moylop260

Copy link
Copy Markdown
Contributor

@legalsylvain

Copy link
Copy Markdown
Contributor

FYI Odoo has the following feature:

odoo/odoo#234710

Hi @moylop260. I see this feature quite dangerous. (disabling all auto_installable modules). I mean there are 2 kind of auto_installable modules IMO :

  • promotional modules, like iap, etc.. Odoo wants to have the module installed widely.
  • fixes / compatibility modules. like sale_stock that should be installed if sale and stock are installed. It makes no sense to disable the installation of sale_stock. Don't you think ? (or did I missed something ?)

@moylop260

Copy link
Copy Markdown
Contributor

Yes, you are right!

They commented in the same PR that in the future they could generate a list to disable auto-install modules like your module

However, they didn't make the improve for master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.