Skip to content

[FIX] keep _register_hook's signature and call super #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanRijnhart wants to merge 2 commits into from
Closed

[FIX] keep _register_hook's signature and call super #340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545bee3
[FIX] keep _register_hook's signature and call super
StefanRijnhart Jan 26, 2016
1055313
[FIX] Odoolint
StefanRijnhart Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions base_optional_quick_create/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from openerp.tools.translate import _


class ir_model(orm.Model):
class IrModel(orm.Model):
_inherit = 'ir.model'

_columns = {
Expand All @@ -37,9 +37,7 @@ def wrapper(cr, uid, name, context=None):
_("Can't create quickly. Opening create form"))
return wrapper

def _register_hook(self, cr, ids=None):
if ids is None:
ids = self.search(cr, SUPERUSER_ID, [])
def _patch_quick_create(self, cr, ids):
for model in self.browse(cr, SUPERUSER_ID, ids):
if model.avoid_quick_create:
model_name = model.model
Expand All @@ -50,14 +48,18 @@ def _register_hook(self, cr, ids=None):
model_obj.check_quick_create = True
return True

def _register_hook(self, cr):
self._patch_quick_create(cr, self.search(cr, SUPERUSER_ID, []))
return super(IrModel, self)._register_hook(cr)

def create(self, cr, uid, vals, context=None):
res_id = super(ir_model, self).create(cr, uid, vals, context=context)
self._register_hook(cr, [res_id])
res_id = super(IrModel, self).create(cr, uid, vals, context=context)
self._patch_quick_create(cr, [res_id])
return res_id

def write(self, cr, uid, ids, vals, context=None):
if isinstance(ids, (int, long)):
ids = [ids]
res = super(ir_model, self).write(cr, uid, ids, vals, context=context)
self._register_hook(cr, ids)
res = super(IrModel, self).write(cr, uid, ids, vals, context=context)
self._patch_quick_create(cr, ids)
return res