Skip to content

[17.0][IMP] module_analysis: Added compatibility with more recent pygount version - #3441

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
commown:17.0-imp-module_analysis-modern_pygount_compat
Nov 7, 2025
Merged

[17.0][IMP] module_analysis: Added compatibility with more recent pygount version#3441
OCA-git-bot merged 1 commit into
OCA:17.0from
commown:17.0-imp-module_analysis-modern_pygount_compat

Conversation

@Honeyxilia

Copy link
Copy Markdown

Based on #3378

pygount 1.4.0 is now very old and current code does not work on recent versions.
It is however easy to improve compatibility accross pygount versions using the
code_count property instead of the code one, which was removed in 2.0.0.
That way, pygount 1.4.0 stays supported but also modern version up to at least
 3.1.0.
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3441-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d47b266. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
OCA-git-bot merged commit 419bd78 into OCA:17.0 Nov 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants