Skip to content

[FIX] onchange_helper: avoid permissions issue - #3492

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-onchange_helper-permissions
Jan 20, 2026
Merged

[FIX] onchange_helper: avoid permissions issue#3492
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-onchange_helper-permissions

Conversation

@SirPyTech

@SirPyTech SirPyTech commented Jan 13, 2026

Copy link
Copy Markdown

Backporting #3375.
@twalter-c2c and other participants to the linked PR @dreispt @grindtildeath @henrybackman you might be interested.

Could not manage to create a test for this, any suggestion is appreciated.

francesco-ooops
francesco-ooops approved these changes Jan 14, 2026
View reviewed changes

@francesco-ooops francesco-ooops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@francesco-ooops

francesco-ooops commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

@dreispt can this be merged? thanks!

twalter-c2c
twalter-c2c approved these changes Jan 16, 2026
View reviewed changes

@twalter-c2c twalter-c2c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have no suggestion on how to add a generic test for this change, to be honest. I had a specific issue that was solved by this fix, but I would not use it as a test case scenario.

@francesco-ooops

francesco-ooops commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

@dreispt ping :)

@OCA-git-bot

OCA-git-bot commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops

francesco-ooops commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@OCA/tools-maintainers can this be merged? thanks!

@thomaspaulb

thomaspaulb commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

/ocabot merge patch

Does this need a forward port to other versions?

@OCA-git-bot

OCA-git-bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3492-by-thomaspaulb-bump-patch, awaiting test results.

@francesco-ooops

francesco-ooops commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@thomaspaulb it's on 18, would make sense to have it on 16 and 17

@OCA-git-bot
OCA-git-bot merged commit f7abe85 into OCA:14.0 Jan 20, 2026
9 checks passed
@OCA-git-bot

OCA-git-bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9a770c5. Thanks a lot for contributing to OCA. ❤️

@thomaspaulb

thomaspaulb commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

If you have the time could you prepare the PRs

@francesco-ooops

francesco-ooops commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@thomaspaulb will try :)

It would be good tho to be consistent on this and have a method to organize backportings as soon as original PRs are merged

This was referenced Jan 28, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@henrybackman henrybackman henrybackman approved these changes
@francesco-ooops francesco-ooops francesco-ooops approved these changes
@twalter-c2c twalter-c2c twalter-c2c approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SirPyTech @francesco-ooops @OCA-git-bot @thomaspaulb @henrybackman @twalter-c2c