[19.0][FIX] upgrade_analysis: don't generate invalid noupdate xml for discarded field values - #3535
Merged
OCA-git-bot merged 1 commit intoMar 3, 2026
Conversation
for discarded field values
Contributor
|
Hi @legalsylvain, @StefanRijnhart, |
1 task
MiquelRForgeFlow
left a comment
Contributor
There was a problem hiding this comment.
Code is not wrong probably, but could you explain/clarify my doubts?
MiquelRForgeFlow
approved these changes
Mar 2, 2026
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 00567e4. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v18, there's currencies set on payment's
payment_method_bank_transferrecord: https://github.com/OCA/OCB/blob/18.0/addons/payment/data/payment_method_data.xml#L593in v19, no currencies are set: https://github.com/OCA/OCB/blob/19.0/addons/payment/data/payment_method_data.xml#L565
which generates
in
noupdate_changes.xml. But this amounts to writing''on a many2many field, which fails as that's an invalid value for this field type.So here I propose to write whatever the field's NULL value is instead, ensuring we generically empty that field in such a case.