Skip to content

[18.0][MIG] field_vector: Migration to 18.0 - #3623

Merged
OCA-git-bot merged 8 commits into
OCA:18.0from
dixmit:18.0-mig-field_vector
Jun 1, 2026
Merged

OCA-git-bot merged 8 commits into
OCA:18.0from
dixmit:18.0-mig-field_vector

Conversation

@etobella

@etobella etobella commented May 22, 2026

Copy link
Copy Markdown
Member

Continues #3589

Also fixed some bugs:

  • On the init, it was declared incorrectly. Fixed it
  • Improved dimensions computation
  • Added some notes on a problem that might arise that could happen.
  • I detected a small license issue
  • Fixed some function declaration errors

@etobella
etobella force-pushed the 18.0-mig-field_vector branch from 7667517 to 1c229df Compare May 22, 2026 09:41
@etobella
etobella force-pushed the 18.0-mig-field_vector branch from 1c229df to a422297 Compare May 22, 2026 15:45
@dnplkndll

Copy link
Copy Markdown
Contributor

@etobella is there a proper way to document the pg extension requirements for a module? nothing in the manifest I guess.

@rvalyi

rvalyi commented May 29, 2026

Copy link
Copy Markdown
Member

@etobella is there a proper way to document the pg extension requirements for a module? nothing in the manifest I guess.

Not any declarative one (not in the manifest) I 'm afraid. But we could log something meaningful in the log if the extension is missing I guess...

@etobella

Copy link
Copy Markdown
Member Author

@sbidoul @lmignon this module has a lot of sense with AI and I will propose a config module by using AI after tjis is merged. Makes sense to keep it here or would be better to port it to github.com/OCA/ai?

@rvalyi

rvalyi commented May 30, 2026

Copy link
Copy Markdown
Member

@sbidoul @lmignon this module has a lot of sense with AI and I will propose a config module by using AI after tjis is merged. Makes sense to keep it here or would be better to port it to github.com/OCA/ai?

I would move it to the ai repo. Another reason is server-tools is already quite bloated...

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@lmignon

lmignon commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@etobella Even though vectors are heavily used in AI, they are also widely used outside of it 😏.

In our case, we use vectors to compute similarities between products by representing attribute values as vectors. This is not AI; it's simply mathematics (or vector arithmetic). https://www.odoo.com/fr_FR/event/odoo-experience-2025-6601/track/vector-based-product-similarity-in-odoo-a-new-paradigm-for-recommendations-8120

That said, it's true that the server-tools repository is packed with a large number of addons, and having a smaller, more focused repository could be beneficial. So I'm not opposed to moving it to the AI repository.

@lmignon

lmignon commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@etobella is there a proper way to document the pg extension requirements for a module? nothing in the manifest I guess.

Not any declarative one (not in the manifest) I 'm afraid. But we could log something meaningful in the log if the extension is missing I guess...

@rvalyi @dnplkndll
This addon don't use additional pg extension since it's not possible with the odoo ORM. It register it's own extension and own datatype designed to properly works with the orm and its internal cache.

@etobella

etobella commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

Well, after your answer, I think we can keep it here and leave the config (includes AI) in the AI repository.

/ocabot migration field_vector

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jun 1, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 1, 2026
42 tasks

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella

etobella commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3623-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit c8b60fc into OCA:18.0 Jun 1, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d47ce02. Thanks a lot for contributing to OCA. ❤️

@etobella
etobella deleted the 18.0-mig-field_vector branch June 1, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants