Skip to content

[19.0][IMP] upgrade_analysis: generate changes for renamed noupdate records - #3671

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
hbrunn:19.0-upgrade_analysis-changed-renamed-noupdate-records
Jul 15, 2026
Merged

OCA-git-bot merged 1 commit into
OCA:19.0from
hbrunn:19.0-upgrade_analysis-changed-renamed-noupdate-records

Conversation

@hbrunn

@hbrunn hbrunn commented Jul 14, 2026

Copy link
Copy Markdown
Member

when a noupdate record is moved into another module, content changes were not reflected in noupdate_changes.xml. A case where that's really problematic is OCA/OpenUpgrade#5812

This fix will emit the following extra records on the next run of the analysis cronjob after merge:

openupgrade_scripts/scripts/uom/19.0.1.0/noupdate_changes.xml (v18, v19)

  <record id="decimal_product_uom" model="decimal.precision" forcecreate="True">
    <field name="name">Product Unit</field>
  </record>

openupgrade_scripts/scripts/hr_holidays/19.0.1.6/noupdate_changes.xml (v18, v19)

  <record id="holiday_status_extra_hours" model="hr.leave.type">
    <field name="icon_id" ref="hr_holidays.icon_4"/>
    <field name="overtime_deductible" eval="False"/>
    <field name="requires_allocation">False</field>
    <field name="country_id" eval="False"/>
    <field name="hide_on_dashboard">True</field>
  </record>

openupgrade_scripts/scripts/base/19.0.1.3/noupdate_changes.xml (v18, v19)

  <record id="dom-tom" model="res.country.group">
    <field name="country_ids" eval="[Command.set([                 ref('yt'),ref('gp'),ref('mq'),ref('gf'),ref('re'),                 ref('pf'),ref('pm'),ref('mf'),ref('bl'),ref('nc'),             ])]"/>
    <field name="code">DOM-TOM</field>
  </record>

openupgrade_scripts/scripts/account/19.0.1.4/noupdate_changes.xml (v18, v19)

  <record id="email_template_edi_self_billing_credit_note" model="mail.template">
    <field name="body_html" type="html">
    ...
    </field>
  </record>

all of which are updates we actually want I think

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @StefanRijnhart, @legalsylvain,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 19.0 milestone Jul 14, 2026

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, usually I had to generate the renamed ones manually.

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-3671-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit cdc6997 into OCA:19.0 Jul 15, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 63acacb. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

@hbrunn what about porting this in v18?

@hbrunn

hbrunn commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@hbrunn what about porting this in v18?

should be a simple cherry pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants