Skip to content

[WIP] from 8.0 to 9.0 base_optional_quick_create - #387

Merged
StefanRijnhart merged 4 commits into
OCA:9.0from
acsone:9.0-mig-base_optional_quick_create-jne
Jul 13, 2016
Merged

StefanRijnhart merged 4 commits into
OCA:9.0from
acsone:9.0-mig-base_optional_quick_create-jne

Conversation

@JonathanNEMRY

Copy link
Copy Markdown
  • bump version to 9.0.1.0.0 and make it installable
  • apply a views/models directory arch into the module
  • fix xpath anchor on ir_model views (osv_memory to transient)
  • add README.rst
  • apply some new api

@pedrobaeza

Copy link
Copy Markdown
Member

This modules shouldn't be migrated to 9.0. As discussed on #300 (comment). We mustn't duplicate features between several modules. The module to be migrated is: https://github.com/OCA/web/tree/8.0/web_m2x_options

@JonathanNEMRY
JonathanNEMRY force-pushed the 9.0-mig-base_optional_quick_create-jne branch from fa3cd92 to d5e800c Compare March 15, 2016 17:05
@sbidoul

sbidoul commented Mar 15, 2016

Copy link
Copy Markdown
Member

@pedrobaeza base_optional_quick_create is a feature accessible to the administrator and applies globally.

OTOH, if I understand well, web_m2x_options can achieve the same result but requires changing the option on all widgets in all the views where they are used.

So IMO it's a different use case and base_optional_quick_create must be kept.

@pedrobaeza

Copy link
Copy Markdown
Member

No, you can apply it globally with a system parameter. Please read the discussion between @StefanRijnhart and me on the link provided to get background about it.

@sbidoul

sbidoul commented Mar 15, 2016

Copy link
Copy Markdown
Member

@pedrobaeza which link?

@pedrobaeza

Copy link
Copy Markdown
Member

Sorry, I though I copied that link, but it was wrong: #300 (comment) (copied also on the original quote).

@pedrobaeza pedrobaeza mentioned this pull request Mar 15, 2016
59 tasks
@sbidoul

sbidoul commented Mar 15, 2016

Copy link
Copy Markdown
Member

I see. We have no budget to work on this at the moment so we'll leave it as is for the moment. I updated #271.

@JonathanNEMRY
JonathanNEMRY force-pushed the 9.0-mig-base_optional_quick_create-jne branch from 52cae13 to d5e800c Compare March 23, 2016 09:20
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 67.082% when pulling 896c02f on acsone:9.0-mig-base_optional_quick_create-jne into 632ce98 on OCA:9.0.

@StefanRijnhart

Copy link
Copy Markdown
Member

I still don't agree with @pedrobaeza. Apparently, base_optional_quick_create has quite a number of sponsors here, and it's technically in a pretty good condition now.

Jonathan Nemry (ACSONE) and others added 3 commits July 12, 2016 18:50
* bump version to 9.0.1.0.0 and make it installable
* apply a views/models directory arch into the module
* fix xpath anchor on ir_model views (osv_memory to transient)
* add README.rst
* apply some new api
@sbidoul
sbidoul force-pushed the 9.0-mig-base_optional_quick_create-jne branch from 896c02f to 4234b1a Compare July 12, 2016 16:51
@sbidoul

sbidoul commented Jul 12, 2016

Copy link
Copy Markdown
Member

rebased and added setup.py cc/ @JonathanNEMRY @Olivier-LAURENT

@JonathanNEMRY

Copy link
Copy Markdown
Author

Thanks @sbidoul ! 👍
Regarding last @StefanRijnhart 's comment do you now agree to take this one as a valid candidate for 9.0 @pedrobaeza ?

@pedrobaeza

Copy link
Copy Markdown
Member

OK, go ahead

@sbidoul

sbidoul commented Jul 13, 2016

Copy link
Copy Markdown
Member

Tested on runbot. 👍

@StefanRijnhart

Copy link
Copy Markdown
Member

Thanks! 👍

@atchuthan

Copy link
Copy Markdown
Member

Tested on runbot 👍

@StefanRijnhart
StefanRijnhart merged commit 67ae4f4 into OCA:9.0 Jul 13, 2016
@JonathanNEMRY

Copy link
Copy Markdown
Author

Thank you all!

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants