[9.0][IMP][auth_supplier] Remove useless group. Mark as customer. - #442
Merged
Merged
Conversation
This was referenced Jun 3, 2016
[9.0][website_portal_invoice_separated] Separate sale and purchase portal documents.
OCA/website#207
Closed
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
The whole purpose of this module was to be able to separate a customer and a supplier portals. Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless. From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff). Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
yajo
force-pushed
the
9.0-auth_supplier-security-remove
branch
from
June 28, 2016 11:11
29aa494 to
c5b18d5
Compare
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole purpose of this module was to be able to separate a customer and a supplier portals.
Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from
base.group_portal, which would give suppliers access to all customers portal. As such, that group becomes useless.From now on, this distinction should be made with simply checking if
user.customeroruser.supplierisTrue. To allow that, I'm implementing what was discussed at #434 (diff).Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
@Tecnativa