Conversation
added 2 commits
August 26, 2026 19:31
…iew_available The tier-validation subtypes are marked default=False in mail_data.xml, so a plain message_subscribe(partner_ids=...) leaves the partner subscribed only to default subtypes. The subsequent message_post(subtype_xmlid='mt_tier_validation_requested', ...) then routes to nobody -- notified_partner_ids ends up empty even though the reviewer's definition has notify_on_pending=True. Mirror what _notify_review_requested already does: pass subtype_ids to message_subscribe and short-circuit when there is no reviewer to notify (avoid posting a stray subtype message that nobody is subscribed to). (cherry picked from commit 6c64fd3eab4240ee34163b979cf3fa5c6a4c7e12)
Adds test_19b_notify_review_available_no_op_when_no_users which calls _notify_review_available directly with a review whose definition has notify_on_pending=False. Asserts no follower is added and no chatter message is posted -- covering the if not users_to_notify: continue guard that codecov flagged. (cherry picked from commit 60d08727d15a0caa5dc7835fded3c1aea949dfe7)
Contributor
|
Hi @LoisRForgeFlow, |
astirpe
marked this pull request as ready for review
August 26, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of OCA/tier-validation#21 (partial) to 18.0:
Problem
When a tier definition has Notify Reviewers on reaching Pending (notify_on_pending) enabled, the reviewer never receives anything.
The chatter shows the "A review has been requested by ..." entry, so the notification looks like it fired — but no mail.mail record is created at all, not even a queued or failed one, and message.notified_partner_ids on the posted message is empty.
notify_on_create on the same definition works correctly, which makes the failure easy to miss: the first tier is notified, later tiers silently are not.
Reproduce