Skip to content

[16.0][MIG] base_user_locale - #780

Merged
OCA-git-bot merged 19 commits into
OCA:16.0from
ForgeFlow:16.0-mig-base_user_locale
Dec 11, 2023
Merged

OCA-git-bot merged 19 commits into
OCA:16.0from
ForgeFlow:16.0-mig-base_user_locale

Conversation

@JordiBForgeFlow

@JordiBForgeFlow JordiBForgeFlow commented Dec 8, 2023

Copy link
Copy Markdown
Member

Standard migration, using #471 as a reference

How was tested:

  1. Make sure that you test with incognito mode in your browser, because it seems that the locale settings are stored in the browser's cache

  2. Introduce the new locale settings in the config:
    Using English (US) as base language, I override the locale into EU standard format:

image

  1. Test
    When creating a sales order I can see that the new format is used:

image

@JordiBForgeFlow

Copy link
Copy Markdown
Member Author

@LoisRForgeFlow @JordiMForgeFlow FYI

@JordiMForgeFlow JordiMForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review 👍🏼

@LoisRForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot migration base_user_locale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 11, 2023
28 tasks

@LoisRForgeFlow LoisRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@LoisRForgeFlow LoisRForgeFlow changed the title [16.0][mig] base_user_locale [16.0][MIG] base_user_locale Dec 11, 2023
@LoisRForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-780-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 03ed5b4 into OCA:16.0 Dec 11, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 69f7cce. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants