[19.0][MIG] spreadsheet_oca: Migration to 19.0

[chrisandrewmann]

Migration of spreadsheet_oca to 19.0

Supersedes #109 by @mpiko. That PR did the bulk of the groundwork and is carried over here. This branch was rebuilt from the current 18.0 branch, previous migration had drifted from 18.0 and lost several merged features (details below).
There were also various issues still outstanding and resolved here.
Relates to #73.

Why this needed a rebuild

While reviewing #109 I found that its migration had overwritten several files with older copies. The commits were present in git ancestry, but the file contents had regressed. The clearest signal was views/spreadsheet_spreadsheet.xml: 240 lines on 18.0, 96 lines on that branch.

Features merged into 18.0 but were absent included:

• [18.0][IMP] spreadsheet_oca: Add Kanban views #84 (kanban views + active) — models/spreadsheet_spreadsheet_tag.py and models/ir_model.py were missing entirely; the kanban view, tags action and both configuration menus were gone from the view file; no active field.
• [18.0][FIX] spreadsheet_oca: Use the correct graphs depending on the type of each one #94 (duplicated graph types) — chart_panel.esm.js was 41 lines vs 67 on 18.0 and still used the old chartRegistry; chartSubtypeRegistry appeared zero times in the branch vs five times on 18.0.
• [18.0][IMP] spreadsheet_oca: Improve pivot side panel to allow modify Pivots from the spreadsheet #92 (modern pivot panel) — partially present only.

This branch starts from the 18.0 preserving all original authorship, with the 19.0 work applied on top.

Carried over from #109 (@mpiko)

• res.groups: category_id and users no longer usable as they were in 18.0
• groups_id → group_ids renames in ir.rule domains and on ir.ui.menu
• _sql_constraints → models.Constraint, and the constraint attribute name must start with an underscore
• inheritable-method-lambda fix on the tag colour default
• _t() → self.env._()
• globalFiltersFieldMatchers → globalFieldMatchingRegistry, with getters as the first argument to every matcher method
• RELATIVE_DATE_RANGE_TYPES → RELATIVE_PERIODS
• loadSpreadsheetDependencies → loadBundle("spreadsheet.o_spreadsheet")
• Removal of the duplicate topbar file / settings registrations now provided by core
• getTableStructure() split into getCollapsedTableStructure() / getExpandedTableStructure()
• web.ListView.Buttons is an empty template in 19.0, so the tree view's xpath-based inheritance had no anchor

Additional fixes made - Found whilst testing locally

Charts

• 19.0 separates figure ids from chart ids. ChartPanel / ChartTypePicker props now carry chartId only, so every this.props.figureId resolved to undefined and the chart menu selector silently did nothing. All 17 references updated across odoo_panels, chart_panels and chart_panel.
• UPDATE_CHART now takes definition, chartId, figureId and sheetId (resolved via getFigureIdFromChartId / getFigureSheetId) instead of id.
• CREATE_CHART now takes figureId, chartId and col/row/offset instead of id and position. The old payload was rejected, so inserting a graph produced an empty spreadsheet.
• Core 19.0 registers all odoo_* chart subtypes itself, so the module's own chartSubtypeRegistry registrations were removed (core provides a superset: 20 subtypes vs the module's 7).
• Core registers 12 odoo_* chart types but the module only provided side panels for odoo_line, odoo_bar and odoo_pie. Editing any other type threw Cannot find odoo_X in this registry!. Panels added for odoo_combo, odoo_scatter, odoo_pyramid, odoo_waterfall, odoo_radar, odoo_sunburst, odoo_treemap, odoo_geo and odoo_funnel.

Global filters

• 19.0 changed filter values from flat shapes to typed objects carrying an operator (relation: {operator, ids}, text: {operator, strings}). Saving a relation filter previously threw No behavior found for filter type "relation" and operator "undefined".
• Core's FilterValue now requires setGlobalFilterValue and globalFilterValue props and no longer dispatches itself; selecting a value threw this.props.setGlobalFilterValue is not a function.
• 19.0 removed rangeType from date filters. Month/quarter/year/relative are now value-level choices, so the "Time range" selector and its branched default-value UI were replaced with core's DefaultDateValue component.

Lists and pivots

• spreadsheet_oca.ListView.Buttons was declared twice for unrelated purposes. The tree-view one is renamed and no longer inherits the now-empty web.ListView.Buttons.
• The "Add to spreadsheet" button anchors after the New button itself rather than after its container, keeping it inside the create-button group as 18.0 style did.
• pivotMode / table structure pairing was inverted.
• SELECT_ODOO_LIST no longer exists in 19.0 and has been dropped.
• The list definition no longer persists the fields dict; data source re-fetches fields on load, so storing them froze a stale schema.

Security

• res.groups.category_id is replaced in 19.0 by privilege_id pointing at a res.groups.privilege record, which carries the category. Simply dropping category_id loses the module's grouping in the user form, so a res.groups.privilege record is created instead.
• res.groups.users renamed to user_ids.
• ir.rule domains use user.all_group_ids rather than direct group membership, so users with an inherited (Manager) rather than direct (User) assignment are matched correctly.

Testing

Installed and tested on local Odoo 19.0 instance.

Manually tested: creating and opening spreadsheets, inserting pivots, lists and graphs from their respective views, editing charts of each type, global filters (date / relation / text), the Data menu, the Import wizard and the list-view upload button.

@mpiko — thanks for the original migration work; please review, since much of this builds on your findings.

[pedrobaeza]

/ocabot migration spreadsheet_oca

[pedrobaeza]

Please squash commit history merging the administrative commits with the one which generates them.

[chrisandrewmann]

Please squash commit history merging the administrative commits with the one which generates them.

Sorry @pedrobaeza , which admin commits do you mean? Can you give example?

[pedrobaeza]

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

[chrisandrewmann]

@pedrobaeza please check commit history now, all done.
I used Claude to help as wasn't confident but ensured it followed the OCA policy, so looks good to me.

[arielbarreiros96]

Hello @chrisandrewmann, thanks for the contribution, I've been reading the code and doing some tests and it looks good to me. I only saw the thing with the new way to use domains (see domain Objects with some examples here), but for this module in particular the domains are so simple that I think we're good to go

[pedrobaeza]

@chrisandrewmann thanks for the squashing. I have overwritten your branch with a bit more of squashing, but the big one were done by you.

Checking the migration itself in runboat, I noted a difference in the behavior: when adding a pivot table to an spreadsheet, the inserted one in 18 was the dynamic pivot, while in this migration, the inserted one is the static one. I remember enterprise to do this second one, but we changed it deliberately.

Can you please check it?

[chrisandrewmann]

@chrisandrewmann thanks for the squashing. I have overwritten your branch with a bit more of squashing, but the big one were done by you.

Checking the migration itself in runboat, I noted a difference in the behavior: when adding a pivot table to an spreadsheet, the inserted one in 18 was the dynamic pivot, while in this migration, the inserted one is the static one. I remember enterprise to do this second one, but we changed it deliberately.

Can you please check it?

@pedrobaeza you're right, I forgot we did that for a reason.
Changes made and force-pushed.

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-122-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 7cf4cd2. Thanks a lot for contributing to OCA. ❤️