[18.0][FIX] spreadsheet_oca: Fixed the fields[col.name] is undefined issue from form view m2o field - #88
Merged
Conversation
Member
|
Steps to reproduce the problem? Check also pre-commit and CIs. |
Contributor
Author
I've resolved the issues with the CI tests. All checks are now passing, and the pipeline is running successfully. |
|
To reproduce:
|
|
@pedrobaeza any other information you need? |
flotho
approved these changes
Jan 20, 2026
flotho
left a comment
Member
There was a problem hiding this comment.
Hi,
Tested on runboat without any issue with the process.
LGTM
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Member
|
There are still no steps to reproduce. |
Isn't this what you are looking for? |
Member
Hi @pedrobaeza , I've tested on runboat with the above procedure. No more issue |
pedrobaeza
approved these changes
Jun 11, 2026
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Checked the problem depicted.
/ocabot merge patch
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 008225c. Thanks a lot for contributing to OCA. ❤️ |
susaglam
added a commit
to susaglam/spreadsheet
that referenced
this pull request
Sep 17, 2026
The OCA 18.0 based frontend used o-spreadsheet and web client APIs that no
longer exist in saas-19.4. Every API was checked against the 19.4 source;
OCA 19.0 was used as an idea reference only.
spreadsheet_oca
- Global filters: globalFieldMatchingRegistry (getters first) replaces the
removed globalFiltersFieldMatchers / RELATIVE_DATE_RANGE_TYPES; default
values use {operator, ids|strings}; date defaults use DefaultDateValue;
FilterValue gets globalFilterValue / setGlobalFilterValue; string domains
for DomainSelector. The edit panel no longer crashes on open.
- Insert flows: pivots use getCollapsed/ExpandedTableStructure (dynamic vs
static), lists use listId and the flat 19.4 definition, graphs create native
bar/line/pie charts with an "odoo" data source and a valid CREATE_CHART
payload. Re-insert from the side panels works; SELECT_ODOO_LIST removed.
- List "Add to spreadsheet" moved to the ListController and waits for the
lazily loaded model (clicks before the renderer mounted were lost); x2many
lists in forms never react (OCA OCA#88 root cause).
- Side panels: OWL3 hooks pass the component scope as first argument, so the
pivot/list panels no longer bind loaders with default parameters.
- Charts: a community "odoo" chart data-source side panel is registered
(community 19.4 only ships "range"); the ChartTypePicker patch that let Odoo
charts become scorecard/gauge and the dead odoo_* chart panels are removed.
- Control panel: parent components are inherited (OCA OCA#112), breadcrumbs and
Dropdown use the 19.4 markup (desktop and 375px), t-slot -> t-call-slot,
graph "Add to spreadsheet" is enabled/disabled on real data.
- getExtraModelCustom() hook lets add-ons extend the model config (OCA OCA#127
idea); image store implements getFile for clipboard copies.
spreadsheet_forecast_oca, spreadsheet_period_comparison_oca
- toNumber with locale, EvaluationError instead of Error, eslint errors
fixed, missing _t strings added to the catalogs.
Tests (throwaway saas-19.4 databases on the test clone, Chrome)
- New browser tours for filters, pivot/list/graph insertion into new and
existing spreadsheets, side-panel re-insert and domain edit, chart panel,
breadcrumbs (desktop + mobile); hoot suites for the formula modules.
- Fresh install with demo: 491 tests, 0 failed, 0 errors.
- Upgrade of the pre-fix database: 489 tests, 0 failed, 0 errors.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…issue