[18.0][FIX] endpoint_route_handler: add missing depends on base - #124
Merged
Merged
Conversation
Contributor
|
Hi @simahawk, |
|
Could you rebase this please |
simahawk
approved these changes
Jun 12, 2026
eduezerouali-tecnativa
approved these changes
Jul 2, 2026
Contributor
|
@juancarlosonate-tecnativa can you rebase pls? |
juancarlosonate-tecnativa
force-pushed
the
18.0-fix-endpoint_route_handler
branch
from
September 16, 2026 07:39
bc526b3 to
4e79704
Compare
Contributor
|
This PR has the |
Contributor
|
/ocabot merge patch To be fwd ported to 19? |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 411334e. Thanks a lot for contributing to OCA. ❤️ |
Contributor
Author
It was included in the migration to 19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an explicit depends key, ir.module.module.dependencies_id remains empty.
As a consequence, _state_update propagates demo=False during installation, since there are no parent modules from which to inherit the demo flag.
This leads to downstream issues: modules depending on this one (e.g., fastapi) fail to load their demo data, because should_have_demo() requires all parent modules to have dbdemo=True.
@Tecnativa