[17.0][FIX] endpoint_auth_api_key: expect 401 when API key is missing - #154
Merged
Merged
Conversation
The `auth_api_key` authentication handler now raises `Unauthorized`: 401 for missing credentials. Update the stale assertion accordingly while retaining `403` for authenticated API keys that lack endpoint permission.
Contributor
|
Hi @simahawk, |
endpoint_auth_api_key: expect 401 when API key is missing
5 tasks
Contributor
Author
|
Hello @simahawk can you pls take a look and possibly trigger merge? |
Contributor
Author
|
Hello @OCA/web-maintainers can you pls take a look and possibly trigger merge? |
StefanRijnhart
approved these changes
Aug 19, 2026
Member
There was a problem hiding this comment.
Thanks! As per OCA/server-auth#805 I see. Basically a port of #106 which could have been named more specifically.
Contributor
Author
|
Hello @ivantodorovich can you pls take a look? |
ivantodorovich
approved these changes
Aug 19, 2026
Member
|
fast tracking as a CI fixing backport /ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 31955d1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
auth_api_keyauthentication handler now raisesUnauthorized: 401 for missing credentials. Update the stale assertion accordingly while retaining403for authenticated API keys that lack endpoint permission.