Skip to content

Dropdown text color overridden when setting navbar background (web_company_color) #3362

Description

@manyanic

Steps to reproduce
1. Set Navbar Background color = #71639e
2. Set Navbar Background Hover color = #695c93
3. Save and reload the page

Current behavior
• The dropdown menu items change color unexpectedly.
• Specifically, the rule at line 110 in custom_colors.1.gen.scss sets:

.dropdown-item {
    color: #374151 !important;
}

This rule overrides the default (white) color of the dropdown text in the navbar, resulting in poor contrast and readability.

Expected behavior
• Dropdown items in the navbar should keep their original text color (white), or at least not be overridden by the color customization.
• The color rule should not apply to dropdowns inside the navbar.

Technical notes
The offending rule appears in custom_colors.1.gen.scss (line 110):

 .dropdown-item {
     color: #374151 !important;
 }

Additional issue
Once a color is set via the color picker, it cannot be unset or cleared (to revert to default behavior). There should be a way to remove a chosen color.

Environment
• Odoo version: 17.0
• Module: web_company_color
• Browser: Chrome / Firefox (any)
• Operating system: macOS

Summary:
The .dropdown-item { color: #374151 !important; } rule unintentionally overrides navbar dropdown text color when custom navbar colors are set.
Also, the color picker lacks an option to unset colors once defined.

Thanks in advance for taking a look! 🙏

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions