Skip to content

[8.0] [ADD] web_tree_date_search - #1056

Merged
simahawk merged 2 commits into
OCA:8.0from
sunflowerit:8.0-web-date-search
Jul 20, 2020
Merged

simahawk merged 2 commits into
OCA:8.0from
sunflowerit:8.0-web-date-search

Conversation

@thomaspaulb

@thomaspaulb thomaspaulb commented Oct 1, 2018

Copy link
Copy Markdown

I really like this module, but the original PR died, @fossoult closed his fork and had not attended reviews since 2016. So have attended for him and replaced #227

@thomaspaulb

Copy link
Copy Markdown
Author

@ovnicraft

Copy link
Copy Markdown
Member

@thomaspaulb 8.0 is not supported. how OCA process this ?

@thomaspaulb would be great if you migrate it at least v10.0

@pedrobaeza

Copy link
Copy Markdown
Member

@ovnicraft, OCA doesn't deprecate versions, so if a contributor wants to contribute an 8.0 module to OCA, he/she can do it.

@ovnicraft

Copy link
Copy Markdown
Member

@pedrobaeza ok, so lets review it

@nikul-serpentcs nikul-serpentcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change

Comment thread web_tree_date_search/__openerp__.py Outdated

@sudhir-erpharbor sudhir-erpharbor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Changes.

Comment thread web_tree_date_search/__openerp__.py Outdated
Comment thread web_tree_date_search/static/src/js/web_tree_date_search.js Outdated
Comment thread web_tree_date_search/static/src/js/web_tree_date_search.js Outdated
@thomaspaulb

Copy link
Copy Markdown
Author

@nikul-serpentcs @sudhir-erpharbor Fixed the javascript code style

@thomaspaulb

Copy link
Copy Markdown
Author

@ovnicraft After polishing a module for 8.0 it usually becomes more easy to migrate to a newer version, so I hope someone will take up the task some day!

@ovnicraft

Copy link
Copy Markdown
Member

@thomaspaulb good contribution !

@nikul-serpentcs nikul-serpentcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomaspaulb squash commit history

Code Review LGTM 👍

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb

Copy link
Copy Markdown
Author

@nikul-serpentcs Doesn't the OCA merge bot squash also?

@simahawk

Copy link
Copy Markdown
Contributor

nope but we can do it manually as this is a new module and we don't need version bumping.

@simahawk
simahawk merged commit 1dc4a89 into OCA:8.0 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants