[8.0] [ADD] web_tree_date_search - #1056
Conversation
|
@thomaspaulb 8.0 is not supported. how OCA process this ? @thomaspaulb would be great if you migrate it at least v10.0 |
|
@ovnicraft, OCA doesn't deprecate versions, so if a contributor wants to contribute an 8.0 module to OCA, he/she can do it. |
|
@pedrobaeza ok, so lets review it |
25ed925 to
6ffe5e3
Compare
6ffe5e3 to
6fe3379
Compare
|
@nikul-serpentcs @sudhir-erpharbor Fixed the javascript code style |
|
@ovnicraft After polishing a module for 8.0 it usually becomes more easy to migrate to a newer version, so I hope someone will take up the task some day! |
|
@thomaspaulb good contribution ! |
nikul-serpentcs
left a comment
There was a problem hiding this comment.
@thomaspaulb squash commit history
Code Review LGTM 👍
|
This PR has the |
|
@nikul-serpentcs Doesn't the OCA merge bot squash also? |
|
nope but we can do it manually as this is a new module and we don't need version bumping. |
I really like this module, but the original PR died, @fossoult closed his fork and had not attended reviews since 2016. So have attended for him and replaced #227