Skip to content

[15.0][MIG] web_widget_char_size: Migration to 15.0 - #2094

Merged
OCA-git-bot merged 7 commits into
OCA:15.0from
BankyKmitl:15.0-mig-web_widget_char_size
May 18, 2024
Merged

[15.0][MIG] web_widget_char_size: Migration to 15.0#2094
OCA-git-bot merged 7 commits into
OCA:15.0from
BankyKmitl:15.0-mig-web_widget_char_size

Conversation

@BankyKmitl

@BankyKmitl BankyKmitl commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

No description provided.

tarteo
tarteo requested changes Nov 25, 2021
View reviewed changes

@tarteo tarteo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Doesn't seem to work:

I've set the option in the view:
image

But I can enter more than 10 characters:
image

Attribute maxlength is not applied:
image

@BankyKmitl
BankyKmitl force-pushed the 15.0-mig-web_widget_char_size branch from 22ef80e to 3159df3 Compare November 25, 2021 10:42
@BankyKmitl

BankyKmitl commented Nov 25, 2021

Copy link
Copy Markdown
Contributor Author

fixed

tarteo
tarteo approved these changes Nov 25, 2021
View reviewed changes

@tarteo tarteo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now. Thanks for your contributions.

@BankyKmitl
BankyKmitl force-pushed the 15.0-mig-web_widget_char_size branch from 3159df3 to 654cf64 Compare December 2, 2021 03:27
@BankyKmitl

BankyKmitl commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

@pedrobaeza Could you check this for a merge?

@dreispt

dreispt commented May 18, 2024

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented May 18, 2024

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2094-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented May 18, 2024

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
OCA-git-bot merged commit e2cc548 into OCA:15.0 May 18, 2024
@OCA-git-bot

OCA-git-bot commented May 18, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 05a016d. Thanks a lot for contributing to OCA. ❤️

This was referenced Jan 29, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt approved these changes
@tarteo tarteo tarteo approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BankyKmitl @dreispt @OCA-git-bot @tarteo @SimoRubi @oca-travis