[MIG] web_advanced_search: Migration to 16.0 by hvgollar · Pull Request #2357 · OCA/web

hvgollar · 2022-12-06T09:01:11Z

No description provided.

StefanRijnhart

Runboat seems broken so I had to do a local install of your version of the module but it does not seem to work for me. The Add advanced filter option is missing from the search filter:

I'm also getting 'missing dependency' errors in the web developer console about this module:

Debug:                    
Object { "@web_advanced_search/js/legacy/CustomFilterItem.esm": {…}, "@web_advanced_search/js/legacy/FilterMenu.esm": {…}, "@web_advanced_search/js/owl/CustomFilterItem.esm": {…}, "@web_advanced_search/js/owl/FilterMenu.esm": {…} }

"@web_advanced_search/js/legacy/CustomFilterItem.esm": Object { dependencies: (3) […], dependents: [], name: "@web_advanced_search/js/legacy/CustomFilterItem.esm", … }

dependencies: Array(3) [ "web.CustomFilterItem", "@web_advanced_search/js/RecordPicker.esm", "@web/core/utils/patch" ]

dependents: Array []

length: 0

<prototype>: Array []

missing: Array [ "@web_advanced_search/js/RecordPicker.esm" ]

0: "@web_advanced_search/js/RecordPicker.esm"

length: 1

<prototype>: Array []

name: "@web_advanced_search/js/legacy/CustomFilterItem.esm"

<prototype>: Object { … }

"@web_advanced_search/js/legacy/FilterMenu.esm": Object { dependencies: (3) […], dependents: [], name: "@web_advanced_search/js/legacy/FilterMenu.esm", … }

dependencies: Array(3) [ "@web_advanced_search/js/legacy/AdvancedFilterItem.esm", "web.FilterMenu", "@web/core/utils/patch" ]

dependents: Array []

missing: Array [ "@web_advanced_search/js/legacy/AdvancedFilterItem.esm" ]

name: "@web_advanced_search/js/legacy/FilterMenu.esm"

<prototype>: Object { … }

"@web_advanced_search/js/owl/CustomFilterItem.esm": Object { dependencies: (3) […], dependents: [], name: "@web_advanced_search/js/owl/CustomFilterItem.esm", … }

dependencies: Array(3) [ "@web/search/filter_menu/custom_filter_item", "@web_advanced_search/js/RecordPicker.esm", "@web/core/utils/patch" ]

dependents: Array []

missing: Array [ "@web_advanced_search/js/RecordPicker.esm" ]

name: "@web_advanced_search/js/owl/CustomFilterItem.esm"

<prototype>: Object { … }

"@web_advanced_search/js/owl/FilterMenu.esm": Object { dependencies: (3) […], dependents: [], name: "@web_advanced_search/js/owl/FilterMenu.esm", … }

dependencies: Array(3) [ "@web_advanced_search/js/owl/AdvancedFilterItem.esm", "@web/search/filter_menu/filter_menu", "@web/core/utils/patch" ]

dependents: Array []

missing: Array [ "@web_advanced_search/js/owl/AdvancedFilterItem.esm" ]

name: "@web_advanced_search/js/owl/FilterMenu.esm"

<prototype>: Object { … }

<prototype>: Object { … }
boot.js:355

Did this module work for you when you were porting it?

nicolascol

review functional LGTM

rven · 2022-12-15T18:35:23Z

@StefanRijnhart Can you verify if everything is fine now?

pablontura · 2022-12-19T12:42:00Z

review functional LGTM

chienandalu

The many2one custom filter is equal to doesn't work:

Full traceback:

OwlError: An error occured in the owl lifecycle (see this Error's "cause" property)
    at handleError (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:16294:35) (/web/static/lib/owl/owl.js:124)
    at owl.App.handleError (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:21844:20) (/web/static/lib/owl/owl.js:5674)
    at Fiber._render (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:17794:30) (/web/static/lib/owl/owl.js:1624)
    at Fiber.render (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:17783:18) (/web/static/lib/owl/owl.js:1613)
    at ComponentNode.updateAndRender (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18607:19) (/web/static/lib/owl/owl.js:2437)

Caused by: TypeError: Cannot read properties of undefined (reading 'detail')
    at CustomFilterItem.onRelationalChanged (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_backend.js:175070:16) (/web_advanced_search/static/src/js/owl/CustomFilterItem.esm.js:75)
    at CustomFilterItem.slot2 (eval at compile (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:21606:16), <anonymous>:136:52) (/web/static/lib/owl/owl.js:5436)
    at callSlot (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:19053:37) (/web/static/lib/owl/owl.js:2883)
    at Dropdown.template (eval at compile (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:21606:16), <anonymous>:33:18) (/web/static/lib/owl/owl.js:5436)
    at Fiber._render (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:17791:38) (/web/static/lib/owl/owl.js:1621)
    at Fiber.render (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:17783:18) (/web/static/lib/owl/owl.js:1613)
    at ComponentNode.updateAndRender (http://oca-web-16-0-pr2357-28f8ea5b62bd.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18607:19) (/web/static/lib/owl/owl.js:2437)

rven · 2023-01-24T15:00:46Z

The error is fixed, but the filter's dropdown will be closed after a selection.

Could anyone suggest what needs to be changed to prevent this?

This does not work anymore

    /**
     * Stop propagation of the autocompleteselect event.
     * Otherwise, the filter's dropdown will be closed after a selection.
     *
     * @override to stop propagating autocompleteselect event
     */
    start: function () {
        this._super(...arguments);
        this.$input.on("autocompleteselect", (event) => event.stopPropagation());
    },

dynapps · 2023-02-03T13:33:20Z

I figured out after long investigation why the Filter menu was closed after selecting a value in the RecordPicker Component.
The selection values are added at this place

This causes the filter menu to be closed, when selecting a value, because it reaches this code in Odoo
https://github.com/odoo/odoo/blob/16.0/addons/web/static/src/core/dropdown/dropdown.js#L277-L305
gotClickedInside results in false, because the ul element doesn't belong to the o_add_custom_filter_menu

If somebody knows a better solution than patching the dropDown component please let me know!

patch(Dropdown.prototype, "dropdown", {
    onWindowClicked(ev) {
        // This patch is created to prevent the closing of the Filter menu
        // when a selection is made in the RecordPicker
        if (
            $(ev.target.closest("ul.dropdown-menu")).attr("id") !== undefined &&
            $(ev.target.closest("ul.dropdown-menu")).attr("id") ===
                $("body > ul.dropdown-menu").attr("id")
        ) {
            return;
        }
        this._super(ev);
    },
});

But for now the solution is working fine!

kmagusiak · 2023-02-17T13:38:00Z

In debug mode, inputting the domain in the editor seems to have no effect. It was a very handy feature if you copy-paste a domain.

pedrobaeza · 2023-02-17T13:39:30Z

But that's something of this module, or something of the domain editor widget of Odoo core?

rven · 2023-02-17T15:16:58Z

But that's something of this module, or something of the domain editor widget of Odoo core?

I think this is something that is fixed by this odoo/odoo#109238

odoo/odoo@a29691b

liebana · 2023-03-07T12:12:06Z

There's a weird behaviour searching in one 2 many fields in custom filter (not in advanced). For example, filtering products that contains product category "furniture" it makes the search, but replaces the text string by "e" in the filter bar.

and replace company icon [FIX] js syntax [FIX] move our patched equals operator to top of list [ADD] support selecting domains on x2x fields [FIX] eval search view's domain [IMP] UI fixes [IMP] reflect recent additions in README.rst [FIX] typos [ADD] translations [FIX] correct js reference [RFR] rebuild our domains in a different way this solves timing problems

I could not find the project on Transifex...

Change fitro by dominio

- Use the new domain widget. - Use modules system.

* Make it good-looking * Update known issues * Fix templates. * Make other operators work again

[MIG] web_advanced_search_x2x: Migrated to 10.0 FIX review Remarks

* Ensure that domain field can be evaluated before creating x2x field * Fixed navigation error after using x2x advanced search

[FIX] StopPropagation when clicking in domain selector.

pedrobaeza · 2023-03-14T18:11:04Z

@StefanRijnhart is it ok for you?

pedrobaeza · 2023-03-14T20:14:00Z

/ocabot migration web_advanced_search

StephaneMangin · 2023-03-23T11:42:45Z

@StefanRijnhart Can you update your review please to go further ? Thanks

vib-adhoc · 2023-04-04T12:19:26Z

Hi @rven , I detected an error with the Odoo Enterprise Timesheets application.

Full traceback:

UncaughtPromiseError > OwlError Uncaught Promise > Cannot find the definition of component "AdvancedFilterItem" OwlError: Cannot find the definition of component "AdvancedFilterItem" at http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:2073:33 at FilterMenu.slot2 (eval at compile (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:2040:370), <anonymous>:69:11) at callSlot (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:1652:25) at Dropdown.template (eval at compile (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:2040:370), <anonymous>:33:18) at RootFiber._render (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:1477:96) at RootFiber.render (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:1476:6) at ComponentNode.render (http://16.odoo.localhost/web/assets/409-49aa605/web.assets_common.min.js:1562:56)

Could you review this before merging?

chienandalu · 2023-04-04T12:55:33Z

@vib-adhoc the compatibility scope for OCA modules is limited to Odoo core (CE) and optionally other OCA modules. Enterprise or other private modules compatibility should be non blocking IMO.

rafaelbn · 2023-04-21T00:49:38Z

Thank you for this great work @hvgollar @rven ! 😄 ❤️

@modon MT-2797

fcvalgar

Functional review.
LGTM, Thank you @hbrunn @StefanRijnhart and all maintainers.

yajo · 2023-04-27T12:58:24Z

I detected an error with the Odoo Enterprise Timesheets application

It turns out that Odoo 16 is still using the web.FilterMenu legacy widget for the also legacy web.ControlPanel widget. Also turns out that the timesheets app uses those legacy widgets.

This PR is removing legacy widget support (which was included for v15). Thus, that app breaks.

This can be considered a regression, because that support was there in the previous version. Happens in the timesheet app, but chances are that it happens on any other custom apps that use legacy widgets too.

A good solution, to avoid supporting those legacy widgets, is to disable the feature on legacy contexts. A better one would be to not remove the files and update them instead.

rven · 2023-04-27T13:04:56Z

I detected an error with the Odoo Enterprise Timesheets application

It turns out that Odoo 16 is still using the web.FilterMenu legacy widget for the also legacy web.ControlPanel widget. Also turns out that the timesheets app uses those legacy widgets.

This PR is removing legacy widget support (which was included for v15). Thus, that app breaks.

This can be considered a regression, because that support was there in the previous version. Happens in the timesheet app, but chances are that it happens on any other custom apps that use legacy widgets too.

A good solution, to avoid supporting those legacy widgets, is to disable the feature on legacy contexts. A better one would be to not remove the files and update them instead.

Ok, I didn't know why those files were in there, I'll have a closer look at them

rven · 2023-04-27T14:44:22Z

Hi @vib-adhoc, I solved the error with the Odoo Enterprise Timesheets application. I also verified it already.

Can you re-test this?

vib-adhoc · 2023-04-27T18:40:36Z

Hi, @rven it works fine!
Thank you

yajo

Tested it on Timesheets too, and elsewhere. Thanks!

/ocabot merge patch

outdated

hbrunn · 2023-04-28T06:42:24Z

I just want to say thank you to everyone involved for how you carried what I once started through all the Odoo versions so far, and making it better on the way 🍰

OCA-git-bot · 2023-04-28T08:08:11Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2357-by-yajo-bump-patch, awaiting test results.

OCA-git-bot · 2023-04-28T08:13:30Z

Congratulations, your PR was merged at 1ce5e9d. Thanks a lot for contributing to OCA. ❤️

augusto-weiss · 2023-05-23T00:18:29Z

Hi everyone!! I notice an error selecting many2one fields in the Custom filter.
When select to add a field "is equal to" and adding an extra condition like the first one, the filter disappears!
Whats about that ?? Somebody know??

@rven @chienandalu @pedrobaeza

Odoo.-.Customers.webm

rven · 2023-05-23T06:46:20Z

@augusto-weiss please check #2513 if this is ok for you?

augusto-weiss · 2023-05-23T12:02:35Z

Hi @rven! Works as expected!! Thanks a lot! i will comment on PR

hvgollar mentioned this pull request Dec 6, 2022

Migration to version 16.0 #2309

Open

47 tasks

StefanRijnhart previously requested changes Dec 6, 2022

View reviewed changes

StefanRijnhart added the work in progress label Dec 7, 2022

hvgollar force-pushed the 16.0-mig-web_advanced_search branch from a213bda to 28f8ea5 Compare December 9, 2022 12:35

nicolascol approved these changes Dec 14, 2022

View reviewed changes

chienandalu suggested changes Jan 13, 2023

View reviewed changes

rven force-pushed the 16.0-mig-web_advanced_search branch 2 times, most recently from 27189d1 to cc89e88 Compare January 24, 2023 15:00

rven force-pushed the 16.0-mig-web_advanced_search branch from cc89e88 to da85bfb Compare February 3, 2023 13:25

hbrunn and others added 13 commits March 7, 2023 14:45

[I18N] FR translation for web_advanced_search_x2x

95b8b81

I could not find the project on Transifex...

[IMP] web_advanced_search_x2x spanish translation

6a2ede8

Change fitro by dominio

web_advanced_search_x2x module

00ad98c

Adapt to v9 API.

5a0eb15

- Use the new domain widget. - Use modules system.

inhibit closing the menu when selecting from the dropdown

24dfdd0

[FIX] web_advanced_search_x2x: Several things

0c984c5

* Make it good-looking * Update known issues * Fix templates. * Make other operators work again

[MIG] web_advanced_search_x2x: Migrated to 10.0

54496be

[MIG] web_advanced_search_x2x: Migrated to 10.0 FIX review Remarks

[FIX] Compatibilize web_widget_domain_v11 with web_advanced_search_x2x

4abb1b5

[FIX] web_advanced_search: 2 fixes

51f535d

* Ensure that domain field can be evaluated before creating x2x field * Fixed navigation error after using x2x advanced search

OCA Transbot updated translations from Transifex

b2c4c84

[UPD] Update web_advanced_search_x2x.pot

e2b3458

[MIG] web_advanced_search_x2x: Migration to 11.0

50928c0

[FIX] StopPropagation when clicking in domain selector.

OCA-git-bot added this to the 16.0 milestone Mar 14, 2023

fcvalgar approved these changes Apr 21, 2023

View reviewed changes

rven force-pushed the 16.0-mig-web_advanced_search branch from 989a042 to dba9530 Compare April 27, 2023 14:41

[MIG] web_advanced_search: Migration to 16.0

c77f504

rven force-pushed the 16.0-mig-web_advanced_search branch from dba9530 to c77f504 Compare April 27, 2023 14:45

hbrunn removed the work in progress label Apr 27, 2023

yajo approved these changes Apr 28, 2023

View reviewed changes

yajo mentioned this pull request Apr 28, 2023

The bot is slow to respond OCA/oca-github-bot#235

Closed

OCA-git-bot added the approved label Apr 28, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 28, 2023

OCA-git-bot merged commit 8b93352 into OCA:16.0 Apr 28, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 28, 2023

Uh oh!

Uh oh!

Conversation

hvgollar commented Dec 6, 2022

Uh oh!

StefanRijnhart left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolascol left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rven commented Dec 15, 2022

Uh oh!

pablontura commented Dec 19, 2022

Uh oh!

chienandalu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rven commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dynapps commented Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmagusiak commented Feb 17, 2023

Uh oh!

pedrobaeza commented Feb 17, 2023

Uh oh!

rven commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liebana commented Mar 7, 2023

Uh oh!

pedrobaeza commented Mar 14, 2023

Uh oh!

pedrobaeza commented Mar 14, 2023

Uh oh!

StephaneMangin commented Mar 23, 2023

Uh oh!

vib-adhoc commented Apr 4, 2023

Uh oh!

chienandalu commented Apr 4, 2023

Uh oh!

rafaelbn commented Apr 21, 2023

Uh oh!

fcvalgar left a comment

Choose a reason for hiding this comment

Uh oh!

yajo commented Apr 27, 2023

Uh oh!

rven commented Apr 27, 2023

Uh oh!

rven commented Apr 27, 2023

Uh oh!

vib-adhoc commented Apr 27, 2023

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

hbrunn commented Apr 28, 2023

Uh oh!

OCA-git-bot commented Apr 28, 2023

Uh oh!

OCA-git-bot commented Apr 28, 2023

Uh oh!

augusto-weiss commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rven commented May 23, 2023

Uh oh!

augusto-weiss commented May 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

StefanRijnhart left a comment •

edited

Loading

nicolascol left a comment •

edited

Loading

chienandalu left a comment •

edited

Loading

rven commented Jan 24, 2023 •

edited

Loading

dynapps commented Feb 3, 2023 •

edited

Loading

rven commented Feb 17, 2023 •

edited

Loading

augusto-weiss commented May 23, 2023 •

edited

Loading