Skip to content

[17.0] mig web chatter position - #2895

Closed
tva-subteno-it wants to merge 16 commits into
OCA:17.0from
tva-subteno-it:17.0-mig-web_chatter_position_2
Closed

tva-subteno-it wants to merge 16 commits into
OCA:17.0from
tva-subteno-it:17.0-mig-web_chatter_position_2

Conversation

@tva-subteno-it

Copy link
Copy Markdown

This a fork from 2833

I know there is another PR currently opened (2893) but this one doesn't seem to work. On the other hand, the original PR (2833) was working fine. So not knowing why the second one was created, and being in the urge to migrate this module for a customer, I'm opening this PR and letting you decide which one works best for you.

@legalsylvain

Copy link
Copy Markdown
Contributor

Could you fix precommit errors ?

@CasVissers-360ERP CasVissers-360ERP left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@antoniocanovas antoniocanovas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok !!

@tva-subteno-it

Copy link
Copy Markdown
Author

Hello everyone, this PR was created because the other PR (#2893) was not ready. But I think it is now. So if anyone of you has the opportunity to do so, can you go check this one out, for the code review, and merge it when ready?
Thanks in advance.

@yajo

yajo commented Dec 3, 2024

Copy link
Copy Markdown
Member

Superseded by #2893.

@yajo yajo closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.