Skip to content

[18.0][MIG] web_widget_dropdown_dynamic: Migration to 18.0 - #3032

Merged
OCA-git-bot merged 22 commits into
OCA:18.0from
HeliconiaIO:18.0-mig-web_widget_dropdown_dynamic
Feb 20, 2025
Merged

OCA-git-bot merged 22 commits into
OCA:18.0from
HeliconiaIO:18.0-mig-web_widget_dropdown_dynamic

Conversation

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

No description provided.

alexey-pelykh and others added 21 commits December 23, 2024 12:37
[UPD] Update web_widget_dropdown_dynamic.pot

[UPD] Update web_widget_dropdown_dynamic_example.pot

[UPD] README.rst

[ADD] icon.png

[UPD] README.rst
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_dropdown_dynamic/es/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-14.0/web-14.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_dropdown_dynamic/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-17.0/web-17.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_widget_dropdown_dynamic/
Currently translated at 100.0% (3 of 3 strings)

Translation: web-17.0/web-17.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_widget_dropdown_dynamic/it/
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_dropdown_dynamic branch from dfc6557 to 32b0abd Compare December 23, 2024 12:54
@CarlosRoca13

Copy link
Copy Markdown
Contributor

/ocabot migration web_widget_dropdown_dynamic

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 24, 2024
49 tasks

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work 😄

Just a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the added empty lines. They are increasing the diff

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlosRoca13 , Thank you for the suggestion.it's Fixed.Please review.

@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_dropdown_dynamic branch from 32b0abd to 5fa3f18 Compare December 25, 2024 06:30
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_dropdown_dynamic branch from 5fa3f18 to a8789ec Compare December 25, 2024 07:36

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: Odoo has added a similar component in the account module. Consider whether this component could be replaced or reused as a base by the Odoo standard in the future.

odoo/odoo@32ec059

TT54527
@Tecnativa @pedrobaeza could you please review this?

@pedrobaeza

Copy link
Copy Markdown
Member

Merging due to the reviews, but we should review where this module were used to try to remove this dependency and use the native one if possible due to the dependency chain.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3032-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit f549069 into OCA:18.0 Feb 20, 2025
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d337333. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.