[18.0][MIG] web_select_all_companies: Migration to 18.0 by natuan9 · Pull Request #3340 · OCA/web

natuan9 · 2025-10-21T08:43:13Z

Changes

The "Select All Companies" feature was added in version 18.0 (from this commit). The "Select All" checkbox is displayed when there are 10 or more companies. In MIG commit, I customized it so that the "Select All" checkbox is displayed when there is more than one company.
Added default_company_ids field to res.users that will control which companies are selected by default

DorianMAG

Thx for the migration.
Functional test on runboat.
LGTM

JulienMartinez

Functional test on runboat.
LGTM
thx

flotho

Hi, thanks,
successfully tested on runboat

OCA-git-bot · 2025-10-26T09:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

natuan9 · 2025-10-27T04:25:47Z

Hi, thanks for your review! I've just made a small change.
Most users don't have access to the res.user form, so we also need to display default_company_ids field in the Preferences form.

ivs-cetmix · 2025-12-22T13:42:32Z

Hey @natuan9 could you please squash the administrative commits (the ones with the [UPD].. tag) if you are comfortable with it?
@flotho could you please check if the recent change is working fine?

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_select_all_companies Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_select_all_companies/

tarteo · 2026-04-16T09:48:23Z

/ocabot migration web_select_all_companies

tarteo

Not sure if we should remove translation files, I couldn't test it on Runboat, but as 3 people already reviewed I assume it's okay!

tarteo · 2026-04-16T09:58:50Z

+This module allows you to select or deselect all the companies in a
+single click.
+
+![image](./static/description/select_all_companies.png)


This file doesn't exist

tarteo · 2026-04-16T10:00:24Z

Don't you want to add your videos here?

HekkiMelody

Aside from the small fixes to the readme that have already been pointed out,

Code and functional review, LGTM

SirPyTech

Thanks for the PR!
I tried it and works great, nice work! 👏

I have reviewed the code and I'm a bit worried of the missing super calls in the overrides, please let me know what you think about those.

I have also reviewed the commit history and some commits from 16.0 are missing, while others should still be squashed.

SirPyTech · 2026-08-25T12:37:40Z

chore: This migration is missing commits d7c496f and following from 16.0, please include them in the correct point of the history.

SirPyTech · 2026-08-25T12:40:22Z

chore: Thanks for squashing some of the administrative commits, I see there are still a few

They have to be squashed too, according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate.

SirPyTech · 2026-08-25T12:46:24Z

praise: Thanks for updating the documentation! That's something most developers skip.

SirPyTech · 2026-08-25T12:47:50Z

question: Maybe you'd like to include this video in the README? Otherwise please remove it.

SirPyTech · 2026-08-25T12:47:56Z

question: Maybe you'd like to include this video in the README? Otherwise please remove it.

SirPyTech · 2026-08-25T12:52:09Z

+class ResUsers(models.Model):
+    _inherit = "res.users"
+
+    default_company_ids = fields.Many2many(


question: This is a new (welcome!) feature, would it be possible to implement it in its own [IMP] commit so it would be easier to backport?

SirPyTech · 2026-08-25T13:06:23Z

+            }
+        }
+
+        this.companyService.setCompanies(selectedIds, false);


suggestion: I'm not that expert as a frontend developer, but I see no super call in this function, would it be possible to add one so the inheritance chain is kept?
You could just set selectedCompaniesIds here and let super's call do the setCompanies, what do you think?

For reference, the function apply in super is https://github.com/odoo/odoo/blob/faa3c4bcabd523bbe5ea0221bcb95597ea004a69/addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js#L51.

SirPyTech · 2026-08-25T13:12:35Z

-                );
-            }, this.constructor.toggleDelay);
-        }
+    async confirm() {


suggestion: Same inheritance considerations of the apply override.

DorianMAG approved these changes Oct 23, 2025

View reviewed changes

JulienMartinez approved these changes Oct 23, 2025

View reviewed changes

OCA-git-bot added the approved label Oct 23, 2025

flotho approved these changes Oct 23, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Oct 26, 2025

natuan9 force-pushed the 18.0-mig-web_select_all_companies branch from 7fbb070 to c7497f3 Compare October 27, 2025 03:57

santostelmo and others added 10 commits December 23, 2025 10:07

[ADD] web_select_all_companies

b7adc0f

[ADD] icon.png

bebc81b

[FIX] web_select_all_companies: wrong link

246982f

[FIX] web_select_all_companies: Title and french translation

8f0df56

web_select_all_companies 16.0.1.0.1

fccc2f5

Added translation using Weblate (Spanish)

f976f77

Update translation files

1e0da1c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_select_all_companies Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_select_all_companies/

Added translation using Weblate (Italian)

48078a2

[IMP] web_select_all_companies: pre-commit auto fixes

2fc4eca

[MIG] web_select_all_companies: Migration to 18.0

4840b6f

natuan9 force-pushed the 18.0-mig-web_select_all_companies branch from c7497f3 to 4840b6f Compare December 23, 2025 03:08

OCA-git-bot added this to the 18.0 milestone Apr 16, 2026

OCA-git-bot mentioned this pull request Apr 16, 2026

Migration to version 18.0 #2945

Open

49 tasks

tarteo reviewed Apr 16, 2026

View reviewed changes

HekkiMelody reviewed Aug 24, 2026

View reviewed changes

SirPyTech suggested changes Aug 25, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Aug 25, 2026

Uh oh!

Conversation

natuan9 commented Oct 21, 2025

Changes

Uh oh!

DorianMAG left a comment

Choose a reason for hiding this comment

Uh oh!

JulienMartinez left a comment

Choose a reason for hiding this comment

Uh oh!

flotho left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 26, 2025

Uh oh!

natuan9 commented Oct 27, 2025

Uh oh!

ivs-cetmix commented Dec 22, 2025

Uh oh!

tarteo commented Apr 16, 2026

Uh oh!

tarteo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HekkiMelody left a comment

Choose a reason for hiding this comment

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants