[19.0][ADD] web_theme_focus: minimal focus backend theme - #3636
volkantasci wants to merge 1 commit into
Conversation
|
Hi @pedrobaeza and @victoralmau 👋 Hope you're having a good week! I wanted to gently ask if anyone could find the time to review this PR when convenient. All CI checks are green (pre-commit, Odoo/OCB tests, codecov, runboat). No rush at all — just checking in. Happy to make any changes you'd like. Thanks for all the work you do for the OCA! |
|
This can be interesting, but having it as a separate module that replaces existing theme sounds very hard. @ljmnoonan proposed in other PR to refactor |
|
@pedrobaeza my proposal is actually to get rid of the theme choice altogether, so we would have just one theme which would change light/dark using odoo's asset bundling mechanism overriding scss variables. Having user selectable themes just adds a lot of complexity for (IMO) no real benefit. Also my branch to refactor |
|
Hi @pedrobaeza and @ljmnoonan, thank you both for the thoughtful feedback — it's really helpful. Quick clarification on the scope of I also understand the argument that a single theme with automatic light/dark is simpler and less complex to maintain than a user-selectable picker. If that's the direction for We can also coordinate with your |
|
Hi @pedrobaeza and @ljmnoonan 👋 a quick follow-up on our side. To clarify the intent behind We fully agree it should not grow into a parallel theming system. We're happy to follow your preferred direction: either contribute the styling into the Thanks for the guidance! |
|
Hi @pedrobaeza @ljmnoonan 👋 Just to align on direction - I understand the preference for a single theme with light/dark via SCSS bundling. Should I close this PR and contribute the Enterprise-inspired styling (gradient + transparent navbar) directly to your 19.0-web_responsive_cleanup branch instead of keeping it as a picker option? Just let me know the preferred path and I will follow it. Thanks! |
|
I think the The commit history should be squashed as well, as it's not adding value right now. |
|
Hi @pedrobaeza, thanks for the guidance - you are right, it should not be confused with Enterprise and we will drop Just to share the ergonomics rationale behind it (not just mimicking Enterprise):
We fully agree to keep it separate from Let me know which name you prefer and I will push the rename in this PR. Thanks again! |
|
OK, you can call it |
d3d0c43 to
f7ea787
Compare
f7ea787 to
1a73020
Compare
|
Hi @pedrobaeza 👋 Renamed to
All CI is now green (pre-commit, Odoo/OCB, dependencies, runboat). Ready for re-review when convenient. Thanks! |
There was a problem hiding this comment.
This icon is old. Check the new OCA one.
| @@ -0,0 +1,4 @@ | |||
| # © 2026 volkantasci | |||
There was a problem hiding this comment.
Don't include copyright in init files.
| @@ -0,0 +1,26 @@ | |||
| # © 2026 volkantasci | |||
There was a problem hiding this comment.
Copyright is put with complete word, not the character.
| @@ -0,0 +1,11 @@ | |||
| <section class="oe_container"> | |||
There was a problem hiding this comment.
This HTML file is generated automatically by pre-commit. And this still mentions enterprise.
1a73020 to
0fbdb23
Compare
…dden search, transparent navbar Extends web_responsive app-menu theme picker with Focus option for few-apps deployments: hidden search bar, larger icons with more spacing, gradient full-bleed with transparent navbar (light+dark). Keeps regular views unchanged. Rename from web_app_theme per review (avoid Enterprise confusion) and squash history.
0fbdb23 to
5098ccb
Compare
|
Hi @pedrobaeza 👋 All 5 review comments addressed in
All CI is green (pre-commit, Odoo/OCB, codecov, dependencies, runboat). Ready for re-review when convenient. Thanks! |
pedrobaeza
left a comment
There was a problem hiding this comment.
Still weird that index.html is not overwritten by the pre-commit, but no problem.
|
Superseded by #3648 (same module, rebased on the current 19.0 tip, single squashed commit, and with the review feedback addressed). Closing this one to keep a single PR. |
Adds
web_theme_focus, a minimal focus backend theme for the app menu.What it does
Extends web_responsive's app-menu theme picker with a Focus option (next to
milk/community) for deployments with few apps:Regular views keep the normal navbar. The module is design-only and does not replicate Odoo Enterprise. Per review, renamed from
web_app_themetoweb_theme_focusand squashed history.Technical notes
web_dark_modeandweb_responsive(selection_add onres.users.apps_menu_themewithfocus)web.assets_backendandweb.assets_web_darkcc @OCA/web-maintainers @pedrobaeza @ljmnoonan