Skip to content

[18.0][IMP] add opt-in setting for automatic PDF invoice preview opening - #3666

Open
vancouver29 wants to merge 1 commit into
OCA:18.0from
vancouver29:18.0-web_responsive-improve_pdf_preview
Open

vancouver29 wants to merge 1 commit into
OCA:18.0from
vancouver29:18.0-web_responsive-improve_pdf_preview

Conversation

@vancouver29

Copy link
Copy Markdown

Improve the PDF preview in web_responsiveModule

Improvements #3334
See this comment for context.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @SplashS, @Tardo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the option should be set per user, not per system.

Comment thread web_responsive/__manifest__.py Outdated
"license": "LGPL-3",
"installable": True,
"depends": ["web", "web_tour", "mail"],
"depends": ["web", "web_tour", "mail", "account"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a total blocker. You can't depend on account.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its changed!

@smaddlsoft

Copy link
Copy Markdown

I think the option should be set per user, not per system.

I was agnostic about this and could see advantage for both, but lets go with your suggestion.
@vancouver29 kindly adjust

@vancouver29
vancouver29 force-pushed the 18.0-web_responsive-improve_pdf_preview branch 3 times, most recently from 24f4964 to 2a87da8 Compare September 15, 2026 10:45
@smaddlsoft

Copy link
Copy Markdown

@vancouver29 I cant see this setting in the users preferences
image

Also, the screenshot in the readme is not working.

Best
Jan

@vancouver29

Copy link
Copy Markdown
Author

@vancouver29 I cant see this setting in the users preferences image

Also, the screenshot in the readme is not working.

Best Jan

Hi Jan @smaddlsoft ,

you should change that option in settings module, not in profile references. Here is the click path:

Settings (Module/App) -> Users & Companies -> Users -> choose the User -> Preferences -> check/uncheck the checkbox in the File Viewer.
I also documented the click path in ‘Usage.md’.

best regards

@smaddlsoft smaddlsoft left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly move the setting to the user preferences accessible by each user, not via settings->users, which most users wont be able to access.

## Auto-open invoice preview

Enable *Auto-open Invoice Preview* in your user preferences
(*Your Profile → Preferences*). When enabled, opening an invoice

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently its not in the users preferences which are accessible directly by the user, but only in the settings->users, which obviously is not accesible by each user.

Kindly move to the user-accsessible user preference window, where also the chatter position is maintained, which is a logical place to put also this opt-in, because both are somewhat related.

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@vancouver29
vancouver29 force-pushed the 18.0-web_responsive-improve_pdf_preview branch from 2a87da8 to c9719b4 Compare September 15, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants