[18.0][FIX] web_widget_pattern: isolate HOOT filter - #3670
Conversation
Temporary reference to the web_widget_pattern HOOT filter fix so this PR's tests do not leak into that suite. Remove after OCA#3670 is merged. Task 5613 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hey @OCA/web-maintainers would appreciate this merged asap, as this can be a blocker for new modules - e.g. the one that's mentioned in this PR. |
Temporary reference to the web_widget_pattern HOOT filter fix so this PR's tests do not leak into that suite. Remove after OCA#3670 is merged. Task 5613 Co-authored-by: Cursor <cursoragent@cursor.com>
etobella
left a comment
There was a problem hiding this comment.
It is usually cleaner to use the standard odoo way of defining JS testing
https://github.com/OCA/automation/blob/18.0/automation_oca/tests/test_js.py
Can you try? Otherwise we can merge
Temporary reference to the web_widget_pattern HOOT filter fix so this PR's tests do not leak into that suite. Remove after OCA#3670 is merged. Task 5613 Co-authored-by: Cursor <cursoragent@cursor.com>
HOOT text filters fuzzy-match other WebWidget* suites. Select this module with WebSuite hash ids, the same way core and automation_oca do, so the suite is isolated without a custom URL filter. Task 5613 Co-authored-by: Cursor <cursoragent@cursor.com>
1af30ef to
9ab0edb
Compare
@etobella thank's for the hint! Applied it, please check. |
|
/ocabot merge patch Fast tracking as this is giving problems to other places |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f9eb80e. Thanks a lot for contributing to OCA. ❤️ |
HOOT treats
filter=WebWidgetPatternas a fuzzy subsequence, so other WebWidget* suites (for example web_widget_autocomplete) run inside this module's browser job. That can fail the pattern tests for unrelated reasons, and it can leave most of the other suite unexecuted.Use a regex filter so only this suite is selected.
Made with Cursor and Ivan who checked the code after it 😄