[9.0][MIG] Migrate help_online to 9.0 - #378
Merged
Merged
Conversation
lmignon
force-pushed
the
9.0-help_online-migration-lmi
branch
from
June 29, 2016 13:08
9f4954f to
19f6396
Compare
Contributor
Author
|
Tested on Odoo 9c et 9e |
| ====================== | ||
|
|
||
| Even if the generated urls to the documentation contains an anchor (website/hel-xx#view_type), | ||
| it's no more possible to insert/edit anchors elemetns into the website since this functionnality is not supported |
Contributor
Author
|
@elicoidal Thank you for the review. Changes done and test coverage improved. |
| <openerp> | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> |
Contributor
There was a problem hiding this comment.
No need for the data tag w/ the new odoo tags
Contributor
|
Rebuilding Runbot for functional, code is 👍 outside of some incredibly minor comments. Also pardon my pun, but that XML and routing work in the wizard was... wizardry 😆 |
| def _manage_images_on_page(self, page_node, data_node, exported_resources): | ||
| """ | ||
| - Extract images from page and generate a xml node | ||
| - Extract images from page and generate an node |
There was a problem hiding this comment.
Nit picking - I believe you meant for the doc string to read:
- Extract images from page and generate an xml node
Contributor
|
Functional as well 🎉 |
lmignon
force-pushed
the
9.0-help_online-migration-lmi
branch
from
August 1, 2016 07:36
3c276d1 to
fff5908
Compare
Contributor
Author
|
@lasley Thank you for the review. Changes done. |
Contributor
|
Changes 👍 thanks @lmignon |
lasley
approved these changes
Sep 15, 2016
JonathanNEMRY
approved these changes
Jan 11, 2017
lmignon
force-pushed
the
9.0-help_online-migration-lmi
branch
from
January 13, 2017 09:58
fff5908 to
17fe006
Compare
Contributor
Author
|
@lasley IMO this one is ready to merge 3 👍 and a proper git history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.