Skip to content

[PORT] 9.0 web_listview_custom_element_number - #559

Merged
pedrobaeza merged 5 commits into
OCA:9.0from
legalsylvain:9.0_PORT_web_listview_custom_element_number
Feb 18, 2017
Merged

pedrobaeza merged 5 commits into
OCA:9.0from
legalsylvain:9.0_PORT_web_listview_custom_element_number

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor
  • port to V9.0, web_listview_custom_element_number that allow users to set a custom quantity of item to display, in any tree view
  • simplify header files
  • apply OCA conventions (readme files)
  • update screenshots
  • improve UI (if user select a predefined item, the tree view will refresh, without need to press return).

For more information, see readme file.

CC

@legalsylvain legalsylvain added this to the 9.0 milestone Feb 17, 2017
@florian-dacosta

Copy link
Copy Markdown

Functional test : it works like a charm!
Thank you Sylvain 👍

@pedrobaeza pedrobaeza mentioned this pull request Feb 18, 2017
55 tasks
@pedrobaeza

Copy link
Copy Markdown
Member

Have you checked if there's new translations in the 8.0 branch with the method from https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#technical-method-to-migrate-a-module-from-80-to-90-branch?

@legalsylvain

Copy link
Copy Markdown
Contributor Author

Hi @pedrobaeza. Thanks for your review. Indeed, i did not follow this process. Thanks for pointing that ! Is it a good practice to squach all commits I recovered ? Or is it better to keep it, for historical reasons ?

Thanks.

@pedrobaeza

Copy link
Copy Markdown
Member

No reason for keeping the exact commit history, as it's already in the previous branch. You have to group by author and logic set (if there are pieces very decoupled that deserves to be kept separately). In this case, you can squash all the commits, as they are from Transbot or a fix that Stéphane applied also to translations. Follow https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests for the Howto.

@legalsylvain
legalsylvain force-pushed the 9.0_PORT_web_listview_custom_element_number branch from 6581ded to 914a485 Compare February 18, 2017 14:27
@legalsylvain

Copy link
Copy Markdown
Contributor Author

@pedrobaeza. done. thanks for this advice.

@pedrobaeza
pedrobaeza merged commit cf45c6d into OCA:9.0 Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants