[PORT] 9.0 web_listview_custom_element_number - #559
pedrobaeza merged 5 commits into
Conversation
|
Functional test : it works like a charm! |
|
Have you checked if there's new translations in the 8.0 branch with the method from https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#technical-method-to-migrate-a-module-from-80-to-90-branch? |
|
Hi @pedrobaeza. Thanks for your review. Indeed, i did not follow this process. Thanks for pointing that ! Is it a good practice to squach all commits I recovered ? Or is it better to keep it, for historical reasons ? Thanks. |
|
No reason for keeping the exact commit history, as it's already in the previous branch. You have to group by author and logic set (if there are pieces very decoupled that deserves to be kept separately). In this case, you can squash all the commits, as they are from Transbot or a fix that Stéphane applied also to translations. Follow https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests for the Howto. |
6581ded to
914a485
Compare
|
@pedrobaeza. done. thanks for this advice. |
For more information, see readme file.
CC