[10.0] [FIX] [web_timeline] Correct write when grouped by by JBF91 · Pull Request #678 · OCA/web

JBF91 · 2017-07-20T07:43:00Z

When you are working with the timeline view and you have grouped your items, you can extend or reduce the time duration of each item, but also change the group they belong, by dragging up or down the record.

I think that changing the group does not work as it should, since is writing the record but having as reference the "default_group_by" defined in the view attrs, instead of the current "group_by" condition defined in the search view box.

I've made a fix and tested myself but just for a while. Hope is useful

oca-clabot · 2017-07-20T07:43:02Z

Hey @JBF91, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@JBF91 (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2017-07-20T07:45:13Z

Thanks for the patch. Please don't add extra blank lines. They don't add anything and make less clear the code read.

pedrobaeza · 2017-07-20T07:45:22Z

And please sign the CLA.

pedrobaeza · 2017-07-20T08:28:01Z

            var self = this;
            var data = [];
            var groups = [];
+            this.grouped_by = group_bys


; at the end

pedrobaeza · 2017-07-20T08:28:21Z

            data[self.fields_view.arch.attrs.date_stop] =
                 time.auto_date_to_str(end, self.fields[self.fields_view.arch.attrs.date_stop].type);
-            data[self.fields_view.arch.attrs.default_group_by] = group;
+            if(self.grouped_by){


space between if and the expression

pedrobaeza · 2017-07-20T08:28:29Z

                 time.auto_date_to_str(end, self.fields[self.fields_view.arch.attrs.date_stop].type);
-            data[self.fields_view.arch.attrs.default_group_by] = group;
+            if(self.grouped_by){
+                data[self.grouped_by[0]] = group


; at the end.

oca-clabot · 2017-11-14T10:22:51Z

Hey @JBF91,
We acknowledge that the following users have signed our Contributor License Agreement:

@JBF91

Appreciation of efforts,
OCA CLAbot

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

[FIX] Correct write when grouped by

e0e95d2

yajo added this to the 10.0 milestone Jul 20, 2017

yajo added the needs review label Jul 20, 2017

Remove blank lines

7795c86

pedrobaeza requested changes Jul 20, 2017

View reviewed changes

Minor changes

ed87793

pedrobaeza approved these changes Jul 20, 2017

View reviewed changes

hbrunn approved these changes Aug 17, 2017

View reviewed changes

hbrunn merged commit e17f516 into OCA:10.0 Aug 17, 2017

Maartincm pushed a commit to Maartincm/web that referenced this pull request Apr 13, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

c1147af

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

mstuttgart pushed a commit to multidadosti-erp/web that referenced this pull request Apr 26, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

ceafdd3

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

fmdl pushed a commit to fmdl/web that referenced this pull request May 1, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

e2b5ca1

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

4a1db2a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

985fd57

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

tarteo pushed a commit to tarteo/web that referenced this pull request Oct 23, 2018

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

5a12aa1

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

thoongnv pushed a commit to thoongnv/web that referenced this pull request Dec 30, 2019

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

b8ee1dc

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Tardo pushed a commit to Tecnativa/web that referenced this pull request Mar 23, 2020

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

79e643a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Tardo pushed a commit to Tecnativa/web that referenced this pull request Mar 30, 2020

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

03834d6

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Yoshiro009 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 17, 2020

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

587ef4a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Murtaza-OSI pushed a commit to ursais/web that referenced this pull request Mar 15, 2021

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

e170b08

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

cesar-tecnativa pushed a commit to Tecnativa/web that referenced this pull request Jul 5, 2022

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

83d6d03

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

cesar-tecnativa pushed a commit to Tecnativa/web that referenced this pull request Jul 5, 2022

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

ef57945

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

CarlosRoca13 pushed a commit to Tecnativa/web that referenced this pull request Aug 2, 2022

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

eec796a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Jan 2, 2023

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

bc8129a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Jan 2, 2023

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

3a96f3d

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Mar 1, 2023

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

97d2ef1

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

peluko00 pushed a commit to APSL/web that referenced this pull request Jul 5, 2024

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

7c1a405

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

EdgarRetes pushed a commit to ursais/web that referenced this pull request Jul 9, 2024

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

2f57ec9

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

carlos-lopez-tecnativa pushed a commit to Tecnativa/web that referenced this pull request Oct 20, 2024

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

e2847b4

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

JasminSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Mar 28, 2025

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

77e111d

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

JasminSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Apr 1, 2025

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

1644ef7

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

JasminSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Apr 21, 2025

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

5631ee5

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

JasminSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request May 9, 2025

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

c07591a

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

bizzappdev pushed a commit to BizzAppDev-Systems/web that referenced this pull request Dec 8, 2025

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

f6db7bf

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

mmaanneell pushed a commit to mmaanneell/web that referenced this pull request May 1, 2026

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

20d78de

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

moduonbot pushed a commit to moduon/web that referenced this pull request May 4, 2026

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

543cafb

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Navigation Menu

Uh oh!

[10.0] [FIX] [web_timeline] Correct write when grouped by - #678

[10.0] [FIX] [web_timeline] Correct write when grouped by#678
hbrunn merged 3 commits into
OCA:10.0from
JBF91:10.0-web_timeline_group_by_fix

JBF91 commented Jul 20, 2017

Uh oh!

oca-clabot commented Jul 20, 2017

Uh oh!

pedrobaeza commented Jul 20, 2017

Uh oh!

pedrobaeza commented Jul 20, 2017

Uh oh!

pedrobaeza Jul 20, 2017

Uh oh!

pedrobaeza Jul 20, 2017

Uh oh!

pedrobaeza Jul 20, 2017

Uh oh!

oca-clabot commented Nov 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

JBF91 commented Jul 20, 2017

Uh oh!

oca-clabot commented Jul 20, 2017

Uh oh!

pedrobaeza commented Jul 20, 2017

Uh oh!

pedrobaeza commented Jul 20, 2017

Uh oh!

pedrobaeza Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

oca-clabot commented Nov 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants