Skip to content

[MIG] website_local_font: Migration to 16.0 - #1051

Open
Reyes4711-S73 wants to merge 3 commits into
OCA:16.0from
Studio73:16.016.0-mig-website_local_font-def
Open

Reyes4711-S73 wants to merge 3 commits into
OCA:16.0from
Studio73:16.016.0-mig-website_local_font-def

Conversation

@Reyes4711-S73

@Reyes4711-S73 Reyes4711-S73 commented Aug 5, 2024

Copy link
Copy Markdown

Standard migration to 16.0
Reopen from #1028

@Reyes4711-S73 Reyes4711-S73 changed the title 16.016.0 mig website local font def [MIG] website_local_font: Migration to 16.0 Aug 5, 2024
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from b097857 to 4a24839 Compare August 5, 2024 06:12
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration website_local_font

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 11, 2024
Comment thread website_local_font/static/src/js/snippets.options.js Outdated
Comment thread website_local_font/static/src/js/snippets.options.js Outdated
Comment thread website_local_font/static/src/xml/website.editor.xml Outdated
Comment thread website_local_font/static/src/xml/website.editor.xml Outdated
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 4a24839 to 84f2984 Compare September 30, 2024 07:16
@Reyes4711-S73

Copy link
Copy Markdown
Author

@xaviedoanhduy Done

@xaviedoanhduy xaviedoanhduy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the above changes

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 11, 2024
13 tasks
@christian-ramos-tecnativa

Copy link
Copy Markdown

Thanks for this @Reyes4711-S73 , do you mind rebasing so we can test it on runboat?

@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch 3 times, most recently from f01dfab to a9b0f21 Compare January 29, 2025 14:13

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.
Please add the versión to the PR title [16.0][MIG] website_local_font: Migration to 16.0
Thanks for the fast response 😄

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Abimael1321

Copy link
Copy Markdown

LGTM! It allows you to import local fonts that are not from Google, the only aspect I detected is that it duplicates and adds the Google fonts, which is already included in Odoo.
Screenshot_1

Comment thread website_local_font/static/src/js/snippets.options.js Outdated
@github-actions

github-actions Bot commented Jun 1, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 1, 2025
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from a9b0f21 to 81c70e9 Compare June 2, 2025 05:54
@Reyes4711-S73

Copy link
Copy Markdown
Author

@OCA/website-maintainers could anyone merge this PR?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tarteo tarteo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

I tried otf and ttf files, but only ttf worked.

Seems that I can only have one local font at a time and I cannot remove it which the screenshots (website_local_font/static/description/NewlyAddedFont.png) suggests it was possible in previous versions.

(non-blocking issue) the font won't be applied in the editor after saving. I need to refresh it
after save:
image
after refresh:
image

It says it's served by google (the blue cloud icon) which is not the case for local fonts.

Vicent-C6 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
@Reyes4711-S73

Copy link
Copy Markdown
Author

@tarteo I reviewed it and I could upload an oft file and it works when you save the changes.
I think this is not blocking to merge this PR, so I recomend you modify your message removing the requested change

@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 5c2d6e2 to 770001a Compare October 13, 2025 05:59
@tarteo

tarteo commented Oct 15, 2025

Copy link
Copy Markdown
Member

@Reyes4711-S73 Did you look at the issue why I can't remove existing uploaded fonts? And why I can only have one local font at the time? This seems to be possible in previous versions,

15.0:

image

16.0:

image
  • No delete button
  • Only one local font can be used, I cannot upload multiple fonts and use them
  • Still it says it comes from Google

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch 2 times, most recently from 85a4db2 to 6a96f38 Compare October 20, 2025 08:56
@Reyes4711-S73

Copy link
Copy Markdown
Author

@tarteo Fixed delete button

@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 6a96f38 to 1b6dc7c Compare November 4, 2025 16:19
@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 1b6dc7c to e8162d0 Compare March 9, 2026 06:52
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 15, 2026
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 19, 2026
bvanjeelharia and others added 3 commits July 27, 2026 13:32
[ADD] website_local_fonts: add new module

[ADD] website_local_fonts: add new module

Updated Test Folder Name

Changes as per suggestions in the PR

Added missing setup file
@Reyes4711-S73
Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from e8162d0 to 4341403 Compare July 27, 2026 11:32
@OCA-git-bot OCA-git-bot added series:16.0 mod:website_local_font Module website_local_font labels Jul 27, 2026
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:website_local_font Module website_local_font series:16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants