Conversation
jans23
force-pushed
the
18.0-add-website_mass_mailing_altcha
branch
2 times, most recently
from
September 12, 2026 17:55
8e0d3d9 to
5e0443e
Compare
jans23
marked this pull request as ready for review
September 12, 2026 18:48
Author
|
@hbrunn maybe you would be willing to review this? |
hbrunn
requested changes
Sep 18, 2026
Comment on lines
+11
to
+24
| altcha_prepend_to: ".js_subscribe_wrap", | ||
| }); | ||
|
|
||
| publicWidget.registry.subscribe.include({ | ||
| altcha_insert_widget() { | ||
| if (this.editableMode || !this.altcha_enabled) { | ||
| return; | ||
| } | ||
| if (!this.el.querySelector("altcha-widget")) { | ||
| this.$el | ||
| .find(this.altcha_prepend_to) | ||
| .append(renderToString("website_altcha.AltchaWidget", {})); | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
instead of doing this, an extra commit changing AltchaBaseFunctionality such that consumers of this class can either set altcha_prepend_to or altcha_append_to seems useful
| } | ||
| }, | ||
|
|
||
| async altcha_get_payload() { |
Member
There was a problem hiding this comment.
all of the following is bullshit. the right thing to do here is override just _onSubscribeClick, wait for verification, attach to the rpc bus to inject the result (and detach the function afterwards), then call super. ~10loc, not 100
jans23
force-pushed
the
18.0-add-website_mass_mailing_altcha
branch
from
September 18, 2026 06:38
5e0443e to
2d6c991
Compare
jans23
force-pushed
the
18.0-add-website_mass_mailing_altcha
branch
2 times, most recently
from
September 18, 2026 07:03
4179487 to
262da5e
Compare
jans23
force-pushed
the
18.0-add-website_mass_mailing_altcha
branch
from
September 18, 2026 07:08
262da5e to
5afb413
Compare
hbrunn
requested changes
Sep 18, 2026
| .append(renderToString("website_altcha.AltchaWidget", {})); | ||
| } | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds ALTCHA support to the newsletter subscription snippets.