[MIG][9.0] website_blog_mgmt: Migrated to V 9.0 - #147
Conversation
There was a problem hiding this comment.
Please use short headers in py files
|
@elicoidal Changes done |
9d736f7 to
15e886f
Compare
|
@pedrobaeza changes done |
|
@sergio-incaser Using short headers doesn't mean the complete remove of the headers. You must preserve the copyright. # -*- coding: utf-8 -*-
# Copyright 2015 ACSONE SA/NV (<http://acsone.eu>)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
There was a problem hiding this comment.
PLZ avoid to reformat the code if the code is not modified. These changes are not necessary and IMO the readability is not improved.
There was a problem hiding this comment.
I agree, although sometimes the style use by the first contributor is not the one of my choice (which in this case, it is), I prefer not to change it because it creates larger diff and add a lot of noise on the needed changes to make this work.
15e886f to
be4368b
Compare
|
@pedrobaeza @elicoidal changes done |
|
👍 LGTM Thank you @sergio-incaser |
|
👍 waiting for Travis |
|
@lmignon @pedrobaeza I remembered now that I changed test_website_blog_flow.py to pass flake8 tests:
|
|
OK, change it then |
|
@sergio-incaser NOK the error in travis comes from website_blog_mgmt/post_init.py:5:1: E302 expected 2 blank lines, found 1 https://travis-ci.org/OCA/website/jobs/105631961#L380 |
|
@lmignon @pedrobaeza All ready. My pep8 local version was old. 😰 |
|
Merging... |
[MIG][9.0] website_blog_mgmt: Migrated to V 9.0
|
@sergio-incaser no stress 😏 |
@lmignon Please can you review? I tested in V9.0