Skip to content

[MIG][9.0] website_blog_mgmt: Migrated to V 9.0 - #147

Merged
pedrobaeza merged 3 commits into
OCA:9.0from
incaser:9.0-blog-mng
Jan 29, 2016
Merged

pedrobaeza merged 3 commits into
OCA:9.0from
incaser:9.0-blog-mng

Conversation

@sergio-teruel

Copy link
Copy Markdown
Contributor

@lmignon Please can you review? I tested in V9.0

@sergio-teruel sergio-teruel changed the title [MIG] website_blog_mgmt: Migrated to V 9.0 [MIG][9.0] website_blog_mgmt: Migrated to V 9.0 Jan 22, 2016
@pedrobaeza pedrobaeza mentioned this pull request Jan 22, 2016
34 tasks
Comment thread website_blog_mgmt/__openerp__.py Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use short headers in py files

@sergio-teruel

Copy link
Copy Markdown
Contributor Author

@elicoidal Changes done

@sergio-teruel

Copy link
Copy Markdown
Contributor Author

@pedrobaeza changes done

@lmignon

lmignon commented Jan 29, 2016

Copy link
Copy Markdown

@sergio-incaser Using short headers doesn't mean the complete remove of the headers. You must preserve the copyright.

# -*- coding: utf-8 -*-
# Copyright 2015 ACSONE SA/NV (<http://acsone.eu>)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLZ avoid to reformat the code if the code is not modified. These changes are not necessary and IMO the readability is not improved.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, although sometimes the style use by the first contributor is not the one of my choice (which in this case, it is), I prefer not to change it because it creates larger diff and add a lot of noise on the needed changes to make this work.

@sergio-teruel

Copy link
Copy Markdown
Contributor Author

@pedrobaeza @elicoidal changes done
@lmignon sorry for the confusion.

@lmignon

lmignon commented Jan 29, 2016

Copy link
Copy Markdown

👍 LGTM Thank you @sergio-incaser

@pedrobaeza

Copy link
Copy Markdown
Member

👍 waiting for Travis

@sergio-teruel

Copy link
Copy Markdown
Contributor Author

@lmignon @pedrobaeza I remembered now that I changed test_website_blog_flow.py to pass flake8 tests:

20:17: E126 continuation line over-indented for hanging indent

@pedrobaeza

Copy link
Copy Markdown
Member

OK, change it then

@lmignon

lmignon commented Jan 29, 2016

Copy link
Copy Markdown

@sergio-incaser NOK the error in travis comes from website_blog_mgmt/post_init.py:5:1: E302 expected 2 blank lines, found 1 https://travis-ci.org/OCA/website/jobs/105631961#L380
That's the only one

@sergio-teruel

Copy link
Copy Markdown
Contributor Author

@lmignon @pedrobaeza All ready. My pep8 local version was old. 😰

@pedrobaeza

Copy link
Copy Markdown
Member

Merging...

pedrobaeza added a commit that referenced this pull request Jan 29, 2016
[MIG][9.0] website_blog_mgmt: Migrated to V 9.0
@pedrobaeza
pedrobaeza merged commit 065f042 into OCA:9.0 Jan 29, 2016
@lmignon

lmignon commented Jan 29, 2016

Copy link
Copy Markdown

@sergio-incaser no stress 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants