[MIG] [9.0] website_breadcrumb by khaeusler · Pull Request #216 · OCA/website

khaeusler · 2016-06-22T10:54:19Z

add the addon website_breadcrumb

oca-clabot · 2016-06-22T10:54:21Z

Hey @khaeusler, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@khaeusler (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2016-06-22T10:56:01Z

Please sign the CLA and use the method explained on https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 instead of modifying commits with your authorship.

mFlayyan · 2016-07-13T12:37:00Z

+        while menu:
+            result.append(menu)
+            menu = menu.parent_id
+        return reversed(result) if revert else result


get all menu parents and include current if include_self is true and reverse the result in case revert is true

That's what it does.

rafaelbn · 2016-07-15T18:08:40Z

Hi @khaeusler , thanks for this contribution. Have you signed the CLA?

khaeusler · 2016-07-21T20:40:59Z

yes

rafaelbn · 2016-07-22T00:58:10Z

I have test it and there is not breadcrum in http://3150711-216-e4d94a.runbot1.odoo-community.org/blog/our-blog-1

@pedrobaeza CLA is OK?

@yajo could you take a look?

khaeusler · 2016-07-22T07:25:50Z

i see the breadcrum here http://3150711-216-e4d94a.runbot1.odoo-community.org/ in the DB 3150711-216-e4d94a-all

rafaelbn · 2016-07-22T11:01:05Z

Hi @khaeusler , sorry. I mean that if you go to the blog there is not breadcrum,

yajo · 2016-08-01T15:57:06Z

Could you please squash all your personal commits? Their messages seem somewhat meaningless and having a single one that adapts to v9 will make it easier to evaluate the v8-v9 diff. Thanks 😊

rafaelbn

Hi, I reviewed again and Breadcrum are missing if you navigate to the blog.

@yajo maybe you can clarify me, please

rafaelbn · 2016-10-04T14:10:14Z

+===================
+
+This module allows you to have breadcrumbs in any page of your website.
+


This doesn't happends, check image:

If an URL is not present in a menu (as indicated in the Configuration section), no breadcrumbs will display.

Definitely worse than OCA/website-cms#1, but much smaller too.

yajo

Almost fine, some things to do.

yajo · 2016-10-11T09:08:50Z

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/186/8.0


yajo · 2016-10-11T09:10:53Z

+===================
+
+This module allows you to have breadcrumbs in any page of your website.
+


If an URL is not present in a menu (as indicated in the Configuration section), no breadcrumbs will display.

Definitely worse than OCA/website-cms#1, but much smaller too.

yajo · 2016-10-11T09:11:06Z

+   :target: https://runbot.odoo-community.org/runbot/186/8.0
+
+.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
+.. branch is "8.0" for example


Remove this.

yajo · 2016-10-11T09:11:24Z

+<https://github.com/OCA/
+website/issues/new?body=module:%20
+website_breadcrumb%0Aversion:%20
+8.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.


Update this section to latest template.

yajo · 2016-10-11T09:11:40Z

+    "name": "Website Breadcrumbs",
+    "summary": "Let you have breadcrumbs in website pages",
+    "version": "9.0.1.0.0",
+    "category": "Uncategorized",


yajo · 2016-10-11T09:13:05Z

+<!-- © 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. - Jairo Llopis
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). -->
+
+<openerp>


yajo · 2016-10-11T09:13:15Z

+<!-- © 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. - Jairo Llopis
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). -->
+
+<openerp>


yajo · 2016-10-11T09:13:30Z

@@ -0,0 +1,95 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
+   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+   :alt: License: AGPL-3


You can move to LGPL if you want.

khaeusler · 2016-11-21T13:25:27Z

Hello,

i don't understand, how can i approve the change requests. I have only the option "Comment". On the other options, i got these messages:

Pull request authors can’t approve their own pull request

and

Pull request authors can’t request changes on their own pull request

I had taken the commits one by one so that the history is preserved.
Should i create a new Branch with one commit of the old website_breadcrumb code?

pedrobaeza · 2016-11-21T17:43:13Z

You can't change that. People that have put that review should change it if they consider that this is correct now.

yajo · 2016-11-22T08:14:42Z

Yes, when changes are requested, you have to make those changes so we can approve them.

I had taken the commits one by one so that the history is preserved.
Should i create a new Branch with one commit of the old website_breadcrumb code?

Nope, it's your story that is to be squashed, then git push -f:

khaeusler · 2016-11-22T09:25:48Z

next try ;-)

pedrobaeza · 2016-11-22T09:26:16Z

Why do you close it?

khaeusler · 2016-11-22T09:26:32Z

close??

khaeusler · 2016-11-22T09:26:43Z

ups, wrong Button, sorry

yajo · 2016-11-22T09:53:45Z

I think you have it mostly. You have to keep the commits that are not yours untouched, but squash those that are yours. Please review #216 (comment) again.

khaeusler · 2016-11-22T19:56:34Z

what is wrong on this changeset?
d1cd215

- increase the version from 8.0.1.0.0 to 9.0.1.0.0 - fix the runbot url to 9.0 - remove <data> in the templates - replace <openerp> with <odoo> in the templates

pedrobaeza · 2016-11-26T17:47:50Z

I have amended commits for you.

lasley

LGTM, code no test

khaeusler · 2016-11-27T15:40:44Z

@pedrobaeza
thanks, but how did you do this?

lasley · 2016-11-27T20:58:59Z

@khaeusler - after the fact may have been a bit different, but the process of splitting commits based on module is part of our upgrade instructions - https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#howto

khaeusler · 2016-11-27T21:46:35Z

oh i see, i used a wrong branch name, should i create a new branch with the name 9.0-mig-website_breadcrumb?

lasley · 2016-11-27T21:52:24Z

No worries on the branch name (although heed for next time). The important part is:

git format-patch --stdout origin/9.0..origin/8.0 -- <module path> | git am -3

which creates a patch of the difference between 8.0 and 9.0, but only for the module path that you define. This splits the commits while preserving ownership, which is likely the process Pedro used to fix this branch.

khaeusler · 2016-11-27T22:50:49Z

@lasley
thanks for the answer

pedrobaeza · 2016-11-28T21:01:15Z

@khaeusler, have you signed the CLA? I can't find it. Who was the sender of the CLA e-mail?

pedrobaeza · 2016-11-28T21:06:35Z

+
+To configure the shown breadcrumbs, you need to:
+
+* Go to *Settings > Configuration > Website Settings > Configure website


Please update the path of this configuration putting: Go to *Website Admin > Configuration* and click on "Configure website menus"

I have updated myself

pedrobaeza

Little comment, but it's working correctly.

pedrobaeza · 2016-11-28T21:11:04Z

Waiting for CLA.

khaeusler · 2016-11-29T11:39:36Z

@pedrobaeza
I've sent you an email

khaeusler · 2016-12-01T19:38:12Z

@pedrobaeza
Have you found the CLA?

lasley · 2016-12-13T15:53:50Z

@rafaelbn - Can you double check that your comments have been attended to please?

rafaelbn · 2016-12-13T16:31:46Z

Rebuilding runbot for testing

rafaelbn · 2016-12-13T17:09:06Z

My comments and doubts from #216 (comment) are pending. Check:

rafaelbn · 2016-12-13T17:09:46Z

OK, I guess is because dependencies. So I merge.

oca-clabot · 2018-12-19T13:21:08Z

Hey @khaeusler,
We acknowledge that the following users have signed our Contributor License Agreement:

@khaeusler

Appreciation of efforts,
OCA CLAbot

pedrobaeza changed the title ~~add the addon website_breadcrumb~~ [MIG] [9.0] website_breadcrumb Jun 22, 2016

rafaelbn added the needs review label Jun 22, 2016

rafaelbn added this to the 9.0 milestone Jun 22, 2016

mFlayyan reviewed Jul 13, 2016
View reviewed changes

pedrobaeza force-pushed the 9.0 branch from c67f6aa to 10a1daa Compare August 18, 2016 15:20

rafaelbn requested changes Oct 4, 2016

View reviewed changes

yajo requested changes Oct 11, 2016

View reviewed changes

lasley added needs fixing and removed needs review labels Oct 22, 2016

khaeusler force-pushed the 9.0 branch from e4d94ae to f19b7ef Compare November 22, 2016 09:24

khaeusler closed this Nov 22, 2016

khaeusler reopened this Nov 22, 2016

khaeusler force-pushed the 9.0 branch from f19b7ef to fe41995 Compare November 22, 2016 19:41

Jairo Llopis and others added 4 commits November 26, 2016 18:47

Align breadcrumbs with page layout, putting them inside a container.

29dff17

OCA Transbot updated translations from Transifex

c914029

Fixes for v9

2889f86

- increase the version from 8.0.1.0.0 to 9.0.1.0.0 - fix the runbot url to 9.0 - remove <data> in the templates - replace <openerp> with <odoo> in the templates

Change the license from AGPL to LGPL

5c44371

pedrobaeza force-pushed the 9.0 branch from d01c3c8 to 5c44371 Compare November 26, 2016 17:47

pedrobaeza added needs review and removed needs fixing labels Nov 26, 2016

lasley approved these changes Nov 26, 2016

View reviewed changes

pedrobaeza reviewed Nov 28, 2016

View reviewed changes

pedrobaeza approved these changes Nov 28, 2016

View reviewed changes

Update README.rst

3314743

yajo approved these changes Dec 13, 2016

View reviewed changes

rafaelbn approved these changes Dec 13, 2016

View reviewed changes

rafaelbn merged commit 76d36fb into OCA:9.0 Dec 13, 2016

pedrobaeza mentioned this pull request Dec 13, 2016

Migration to version 9.0 #85

Closed

34 tasks

		===================

		This module allows you to have breadcrumbs in any page of your website.


		To configure the shown breadcrumbs, you need to:

		* Go to *Settings > Configuration > Website Settings > Configure website

Uh oh!

Conversation

khaeusler commented Jun 22, 2016

Uh oh!

oca-clabot commented Jun 22, 2016

Uh oh!

pedrobaeza commented Jun 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jul 15, 2016

Uh oh!

khaeusler commented Jul 21, 2016

Uh oh!

rafaelbn commented Jul 22, 2016

Uh oh!

khaeusler commented Jul 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelbn commented Jul 22, 2016

Uh oh!

yajo commented Aug 1, 2016

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khaeusler commented Nov 21, 2016

Uh oh!

pedrobaeza commented Nov 21, 2016

Uh oh!

yajo commented Nov 22, 2016

Uh oh!

khaeusler commented Nov 22, 2016

Uh oh!

pedrobaeza commented Nov 22, 2016

Uh oh!

khaeusler commented Nov 22, 2016

Uh oh!

khaeusler commented Nov 22, 2016

Uh oh!

yajo commented Nov 22, 2016

Uh oh!

khaeusler commented Nov 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Nov 26, 2016

Uh oh!

lasley left a comment

Choose a reason for hiding this comment

Uh oh!

khaeusler commented Nov 27, 2016

Uh oh!

lasley commented Nov 27, 2016

Uh oh!

pedrobaeza commented Jun 22, 2016 •

edited

Loading

khaeusler commented Jul 22, 2016 •

edited

Loading

khaeusler commented Nov 22, 2016 •

edited

Loading

lasley commented Nov 27, 2016 •

edited

Loading