[9.0] [MIG] website_blog_share module - #291
Conversation
c9d5079 to
a93f57c
Compare
| { | ||
| "name": "Blog Share", | ||
| "version": "9.0.1.0.0", | ||
| "author": "Tecnativa," |
|
Sorry @andhit-r Check if all is right now. |
|
No worries @cubells. Tested functionally on runbot 👍 |
yajo
left a comment
There was a problem hiding this comment.
Code OK. Functional not possible due to dead runbot, but I guess it should work fine.
| <a class="oe_share_twitter" t-attf-href="https://twitter.com/intent/tweet?text={{blog.website_meta_title}}&url={url}" target="_Blank"><i class="fa fa-twitter"/> </a> | ||
| <a class="oe_share_linkedin" t-attf-href="http://www.linkedin.com/shareArticle?mini=true&url={url}&title={{blog.website_meta_title}}" target="_Blank"><i class="fa fa-linkedin"/> </a> | ||
| <a class="oe_share_google" t-attf-href="https://plus.google.com/share?url={url}" target="_Blank"><i class="fa fa-google-plus-square"/> </a> | ||
| <a href="mailto:?body={url}&subject={title}"><i class="fa fa-envelope-o"> </i></a> |
There was a problem hiding this comment.
But that shouldn't be static... How do you tell your phone to share the content and make appear the share dialog? Is there a standard HTML way?
There was a problem hiding this comment.
well, all others are hardcoded. No standard so far, although all browsers have the option nowadays.
There was a problem hiding this comment.
Yeah, they are hardcoded, but I thought that maybe there was a way to handle it. WhatsApp link will only work on mobile with it installed, so I see it as not a good choice. The other can be an addition indeed. I'm thinking that it would best to have a general website_share module (or even use any from standard - does it exists?), and that module can be improved for adding services. Of course, there's the need of allowing to configure in which services to share.
There was a problem hiding this comment.
yes, that would be great. Maybe we can add all this to roadmap to not block this migration.
There was a problem hiding this comment.
Yes, of course this is not blocking. They were just some thoughts.
|
@cubells, please squash Andithia's commits together, as they are meaningless. |
3147a9d to
782b2d5
Compare
fa938ea to
3f1c96c
Compare
3f1c96c to
811eb61
Compare
|
Merging as the error is not in this module. |
@Tecnativa