Skip to content

[INIT] website_menu_multilang - #3

Merged
gurneyalex merged 8 commits into
OCA:8.0from
andrius-preimantas:8.0
May 28, 2015
Merged

gurneyalex merged 8 commits into
OCA:8.0from
andrius-preimantas:8.0

Conversation

@andrius-preimantas

Copy link
Copy Markdown

No description provided.

Comment thread website_menu_multilang/__init__.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use from . import model

@pedrobaeza

Copy link
Copy Markdown
Member

Check also some flake8 line length.

Thanks for the contribution!

@andrius-preimantas

Copy link
Copy Markdown
Author

Hi Pedro,

Thanks for your comments. I've update PR based on your comments. Hope everything is OK now.

Cheers
Andrius

@pedrobaeza

Copy link
Copy Markdown
Member

Please fix PEP8 errors:

./website_menu_multilang/__openerp__.py:3:43: W291 trailing whitespace
./website_menu_multilang/__openerp__.py:4:67: W291 trailing whitespace
./website_menu_multilang/__openerp__.py:40:80: E501 line too long (85 > 79 characters)

Comment thread website_menu_multilang/model/website.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also consider the case where there are no lang_ids specified. I think the best approach is to return True in that case, so no languages=no filter; any language=filter by that language.

@andrius-preimantas

Copy link
Copy Markdown
Author

Hi

PR updated.

Cheers

@pedrobaeza

Copy link
Copy Markdown
Member

Thank you for all the changes.

👍

Comment thread website_menu_multilang/__openerp__.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set 'Versada UAB,Odoo Community Association (OCA)' as author please?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@oca-clabot

Copy link
Copy Markdown

Hey @andrius-preimantas, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@gurneyalex

Copy link
Copy Markdown
Member

CLA ok for @andrius-preimantas

@eLBati

eLBati commented May 7, 2015

Copy link
Copy Markdown
Member

👍

@OSguard

OSguard commented May 27, 2015

Copy link
Copy Markdown

@hbrunn can you merge this?
I have no merge rights in this repository

gurneyalex added a commit that referenced this pull request May 28, 2015
[INIT] website_menu_multilang
@gurneyalex
gurneyalex merged commit 6605809 into OCA:8.0 May 28, 2015
@oca-clabot

Copy link
Copy Markdown

Hey @andrius-preimantas,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

bealdav pushed a commit to akretion/website that referenced this pull request Feb 10, 2017
Add base files for the branch (.travis.yml, .coveragerc, .gitignore, README.md, LICENSE)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants