[INIT] website_menu_multilang - #3
Conversation
|
Check also some flake8 line length. Thanks for the contribution! |
|
Hi Pedro, Thanks for your comments. I've update PR based on your comments. Hope everything is OK now. Cheers |
|
Please fix PEP8 errors: |
There was a problem hiding this comment.
You should also consider the case where there are no lang_ids specified. I think the best approach is to return True in that case, so no languages=no filter; any language=filter by that language.
|
Hi PR updated. Cheers |
|
Thank you for all the changes. 👍 |
There was a problem hiding this comment.
Can you set 'Versada UAB,Odoo Community Association (OCA)' as author please?
|
Hey @andrius-preimantas, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
CLA ok for @andrius-preimantas |
|
👍 |
|
@hbrunn can you merge this? |
[INIT] website_menu_multilang
|
Hey @andrius-preimantas, Appreciation of efforts, |
Add base files for the branch (.travis.yml, .coveragerc, .gitignore, README.md, LICENSE)
No description provided.