[10.0] Migrate website legal page to version 10.0 #310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| __import__('pkg_resources').declare_namespace(__name__) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| __import__('pkg_resources').declare_namespace(__name__) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../website_legal_page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import setuptools | ||
|
|
||
| setuptools.setup( | ||
| setup_requires=['setuptools-odoo'], | ||
| odoo_addon=True, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from . import controllers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from . import main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright 2017 LasLabs Inc. | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from odoo import http | ||
| from odoo.addons.website.controllers.main import Website | ||
|
|
||
|
|
||
| class Legal(Website): | ||
|
|
||
| @http.route([ | ||
| '/legal', | ||
| '/legal/<string:page>', | ||
| ], | ||
| auth='public', | ||
| type='http', | ||
| website=True, | ||
| ) | ||
| def show(self, page='legal'): | ||
| return self.page('website_legal_page.%s' % page) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * website_legal_page | ||
| # | ||
| # Translators: | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: website (9.0)\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2016-11-29 03:55+0000\n" | ||
| "PO-Revision-Date: 2016-05-26 15:27+0000\n" | ||
| "Last-Translator: <>\n" | ||
| "Language-Team: Bulgarian (http://www.transifex.com/oca/OCA-website-9-0/language/bg/)\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Language: bg\n" | ||
| "Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid ", and the" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid ", the" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "I accept the" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.legal_advice_link | ||
| msgid "Legal advice" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.privacy_policy_link | ||
| msgid "Privacy policy" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.terms_of_use_link | ||
| msgid "Terms of use" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "legal advice" | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "of this website." | ||
| msgstr "" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "privacy policy" | ||
| msgstr "политика за личните данни" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "terms of use" | ||
| msgstr "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * website_legal_page | ||
| # | ||
| # Translators: | ||
| # Pedro Castro Silva <pedrocs@sossia.pt>, 2016 | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: website (9.0)\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2016-12-24 04:17+0000\n" | ||
| "PO-Revision-Date: 2016-12-17 18:52+0000\n" | ||
| "Last-Translator: Pedro Castro Silva <pedrocs@sossia.pt>\n" | ||
| "Language-Team: Portuguese (Portugal) (http://www.transifex.com/oca/OCA-website-9-0/language/pt_PT/)\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Language: pt_PT\n" | ||
| "Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid ", and the" | ||
| msgstr ", e o" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid ", the" | ||
| msgstr ", o" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "I accept the" | ||
| msgstr "Aceitos os" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.legal_advice_link | ||
| msgid "Legal advice" | ||
| msgstr "Aconselhamento jurídico" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.privacy_policy_link | ||
| msgid "Privacy policy" | ||
| msgstr "Política de privacidade" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.terms_of_use_link | ||
| msgid "Terms of use" | ||
| msgstr "Termos de utilização" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "legal advice" | ||
| msgstr "aconselhamento jurídico" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "of this website." | ||
| msgstr "deste website." | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "privacy policy" | ||
| msgstr "política de privacidade" | ||
|
|
||
| #. module: website_legal_page | ||
| #: model:ir.ui.view,arch_db:website_legal_page.acceptance_full | ||
| msgid "terms of use" | ||
| msgstr "termos de utilização" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import test_controller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright 2017 LasLabs Inc. | ||
| # License APL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo.tests.common import HttpCase | ||
|
|
||
|
|
||
| class TestController(HttpCase): | ||
|
|
||
| def test_legal(self): | ||
| """ It should return a 200 for the default page. """ | ||
| response = self.url_open('/legal') | ||
| self.assertEqual( | ||
| response.getcode(), | ||
| 200, | ||
|
Member
There was a problem hiding this comment. This will change with my above comment. |
||
| ) | ||
|
|
||
| def test_unknown(self): | ||
| """ It should return a 404 for unknown pages. """ | ||
| response = self.url_open('/legal/no-page') | ||
| self.assertEqual( | ||
| response.getcode(), | ||
| 404, | ||
| ) | ||
|
|
||
| def test_privacy(self): | ||
| """ It should return a 200 for a defined page. """ | ||
| response = self.url_open('/legal/privacy') | ||
| self.assertEqual( | ||
| response.getcode(), | ||
| 200, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SEO-wise, if you have a
/legaland a/legal/legalpage that are the same, you get penalized.I think you should better not add a default page and require it (404 error otherwise), or make it redirect to
/legal/legalifnot page.Remember to add
**kwargsso that we can add?debug=assetsand so on.Also, this controller's name should be
legalinstead ofshowIMHO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/legalis the default route here. I guess technically/legal/legalwould work too, but I'm pretty sure I rigged everything up as/legalUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, you're recommending explicitly denying (still early here, need coffee).
What about
/legal/overviewor something? I don't like the one duplicated