[9.0][MIG][website_crm_quick_answer] - #321
Merged
Merged
Conversation
yajo
force-pushed
the
9.0-website_crm_quick_answer-mig
branch
from
February 16, 2017 14:12
368fd57 to
9d8f5e3
Compare
pedrobaeza
approved these changes
Feb 21, 2017
Member
Author
|
Odoo rejected odoo/odoo#15528, so it's now included in the addon, and will have to be this way until v11, so it's explained in README. Ready to review then. |
cubells
approved these changes
May 15, 2017
cubells
left a comment
Member
There was a problem hiding this comment.
👍
LGTM
Code review and tested.
Remove unexisting field. Filter by medium too. Allowing all users to read filter when creating a lead or an opportunity OCA Transbot updated translations from Transifex
Migration includes: - Drop filter and use the new domain field in the automated action. - Migration script to avoid FK error when dropping it. - Warn about non-immediate response. [FIX][website_crm_quick_answer] Include odoo/odoo#15528 Patch was rejected upstream, so we will maintain it here for v9 and v10. Fix lint error
yajo
force-pushed
the
9.0-website_crm_quick_answer-mig
branch
from
May 30, 2017 08:10
8e68e8a to
b514c4c
Compare
Member
Author
|
Rebased, it should go green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration includes:
This will only work after @odoo merges odoo/odoo#15528, so I'll label as WIP until then. However, code is stable.
@Tecnativa