[10.0] [MIG] website_legal_page by lasley · Pull Request #353 · OCA/website

lasley · 2017-06-13T16:36:50Z

I didn't want to keep submitting PRs to an edge branch, so I'm superseding #310 with this.

@yajo - I completed your #310 (review) in 8f3c7b2, which I will squash into 311c6ca before merge.

OCA Transbot updated translations from Transifex

yajo

Check bots please.

yajo · 2017-06-14T07:36:26Z

+        website=True,
+    )
+    def show_legal_page(self, **kwargs):
+        return self.page('website_legal_page.%s' % page, kwargs)


This will fail! page is undefined.

yajo · 2017-06-14T07:38:31Z

 </template>

-<template id="website.legal" name="Legal advice" page="True">
+<template id="legal" name="Legal Advice" page="True">


id should be advice instead, as in line 9

yajo · 2017-06-14T07:38:53Z

 </template>

-<template id="website.privacy" name="Privacy policy" page="True">
+<template id="privacy" name="Privacy Policy" page="True">


ID here must be privacy-policy, like in line 9

yajo · 2017-06-14T07:39:10Z

 </template>

-<template id="website.terms" name="Terms of use" page="True">
+<template id="terms" name="Terms of use" page="True">


And here, terms-of-use

yajo · 2017-06-14T07:39:55Z

+        response = self.url_open('/legal/no-page')
+        self.assertEqual(
+            response.getcode(),
+            404,


It would be nice to add a test like this for just /legal

yajo · 2017-06-14T07:40:33Z

+
+    def test_privacy(self):
+        """ It should return a 200 for a defined page. """
+        response = self.url_open('/legal/privacy')


It would be nice to add a test like this for each of the 3 pages.
BTW, you said it would be privacy-policy instead. Check below.

lasley · 2017-06-14T18:21:56Z

Hah bots are part of the reason that I just took the PR over - I obviously tested nothing! Fixed.

yajo

OK, it seems good enough for me 😊

However, I still want to add a couple of warnings we might want to fix now:

Current design of pages will hit odoo/odoo#15437.
Changing XMLIDS of legal pages will make old ones disappear and new ones get new. I'm pretty sure many people will not want to reach their lawyers again to re-fix their lost legal terms, so a migration script from <10.0 versions would be very desirable.

lasley · 2017-06-15T15:57:13Z

Hmmm I'm not sure I totally understand the number 1 point. What do I need to do here in order to avoid that?

Regarding the migration script - isn't that better suited for OpenUpgrade?

pedrobaeza · 2017-06-15T19:34:44Z

In this case I don't think we should provide separate views for "content containers", as someone may want to modify the entire legal page without keeping the default layout.

yajo · 2017-06-16T08:44:23Z

What do I need to do here in order to avoid that?

Yes, @pedrobaeza, but just in case @lasley wants to avoid that: just replace those <div class="oe_content"/> by <t t-call="website_legal_page.${page}_content"/> and adding that view as a separate one that just contains <div class="oe_content"/>.

* Move legal pages to explicit /legal routes Fixes by PR review Fix my obvious lack of testing

- Update copyright headers. - Update copyright holders data. - Remove .pot file. - Add migration script.

yajo · 2017-06-30T09:15:51Z

@lasley I took the freedom to squash your last commits to get it ready to merge. I also added the required migration script, so this should be ready to merge now.

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

pedrobaeza · 2017-06-30T09:31:37Z

Merging then

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

lasley · 2017-06-30T18:03:46Z

You're awesome, thanks @yajo! Been backed up with the deploys and totally wasn't able to get back to this. Excellent community effort!

yajo · 2017-07-04T12:43:43Z

Anyone interested on this please take a look at #358

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

oca-transbot and others added 3 commits January 9, 2017 12:53

OCA Transbot updated translations from Transifex

a2dc5df

OCA Transbot updated translations from Transifex

[MIG] website_legal_page: Migrated to 10.0

a46c1a0

[ADD] setup.py

9082adb

lasley added the needs review label Jun 13, 2017

lasley added this to the 10.0 milestone Jun 13, 2017

lasley mentioned this pull request Jun 13, 2017

[10.0] Migrate website legal page to version 10.0 #310

Closed

lasley force-pushed the hurrinico-10.0-mig-website_legal_page branch 3 times, most recently from aaeaf4b to acd5fab Compare June 13, 2017 18:34

lasley requested a review from yajo June 13, 2017 20:25

yajo requested changes Jun 14, 2017

View reviewed changes

lasley force-pushed the hurrinico-10.0-mig-website_legal_page branch 2 times, most recently from 5e3d9dc to 3e6ff23 Compare June 14, 2017 18:53

yajo approved these changes Jun 15, 2017

View reviewed changes

lasley and others added 2 commits June 30, 2017 11:06

[IMP] website_legal: Move to explicit route

f0db4a9

* Move legal pages to explicit /legal routes Fixes by PR review Fix my obvious lack of testing

[MIG][website_legal_page] Migration script and polish

37bf49a

- Update copyright headers. - Update copyright holders data. - Remove .pot file. - Add migration script.

yajo force-pushed the hurrinico-10.0-mig-website_legal_page branch from 3e6ff23 to 37bf49a Compare June 30, 2017 09:15

yajo self-assigned this Jun 30, 2017

yajo added a commit to hurrinico/website that referenced this pull request Jun 30, 2017

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

7fb1971

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

hurrinico mentioned this pull request Jun 30, 2017

[10.0] Migrate website cookie notice #309

Merged

1 task

pedrobaeza mentioned this pull request Jun 30, 2017

Migration to version 10.0 #262

Closed

35 tasks

pedrobaeza merged commit 5411bca into OCA:10.0 Jun 30, 2017

yajo added a commit to hurrinico/website that referenced this pull request Jun 30, 2017

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

d2015d1

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

lasley deleted the hurrinico-10.0-mig-website_legal_page branch June 30, 2017 18:03

yajo mentioned this pull request Jul 4, 2017

[FIX][website_legal_page] Fix links in reusable template #358

Merged

lasley pushed a commit to LasLabs/website that referenced this pull request Aug 11, 2017

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

c574086

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

njeudy pushed a commit to njeudy/website that referenced this pull request Jan 11, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

f0d18be

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

njeudy pushed a commit to njeudy/website that referenced this pull request Jan 23, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

0b510f3

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

njeudy pushed a commit to njeudy/website that referenced this pull request Jan 26, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

0985e9c

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

eLBati pushed a commit to eLBati/website that referenced this pull request Oct 1, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

de2947f

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

ernestotejeda pushed a commit to Tecnativa/website that referenced this pull request Nov 20, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

2c04e9f

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

pedrobaeza pushed a commit to Tecnativa/website that referenced this pull request Dec 13, 2018

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

32759d7

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

bjornbillen pushed a commit to bjornbillen/website that referenced this pull request Jan 15, 2020

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

da1966b

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

bjornbillen pushed a commit to bjornbillen/website that referenced this pull request Feb 7, 2020

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

d1bebcc

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

Tardo pushed a commit to Tecnativa/website that referenced this pull request Apr 14, 2020

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

1efdcf9

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

Tardo pushed a commit to Tecnativa/website that referenced this pull request Apr 14, 2020

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

18c5452

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

ivantodorovich pushed a commit to odoo-it/website that referenced this pull request Dec 28, 2020

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

a9ce9bb

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

ivantodorovich pushed a commit to odoo-it/website that referenced this pull request Apr 20, 2021

[MIG][website_cookie_notice] Adapt to OCA#353 and polish

bd2b2f7

- Privacy policy URL changed. - Contributors data updated. - Move templates to templates folder, as per guidelines.

Uh oh!

Conversation

lasley commented Jun 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

yajo Jun 14, 2017

Choose a reason for hiding this comment

Uh oh!

lasley commented Jun 14, 2017

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

lasley commented Jun 15, 2017

Uh oh!

pedrobaeza commented Jun 15, 2017

Uh oh!

yajo commented Jun 16, 2017

Uh oh!

yajo commented Jun 30, 2017

Uh oh!

pedrobaeza commented Jun 30, 2017

Uh oh!

lasley commented Jun 30, 2017

Uh oh!

yajo commented Jul 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lasley commented Jun 13, 2017 •

edited

Loading