[MIG] website_logo: Migration to 10.0 - #357
Conversation
Changes include: - update version number - make module installable - In company_view use an xpath expression to add logo configuration to company view.
In view, logo field should come after the 'Domain' group, which is the first group when searching by XPath.
Tests are taken from commit: c1c9d53
…* Remove duplicated http send in favor of pass * Fix broken test for exception handling
* [FIX] website_logo: show logo by domain Use domain field to match a logo by website instead of the name field of the website model. * [FIX] website_logo update readme The logo is now configured from 'Website admin' instead of 'Company settings'.
pedrobaeza
left a comment
There was a problem hiding this comment.
Little changes, but working on runbot
|
|
||
| * go to your company and load a logo image in the website logo field | ||
| * Go to 'Website Admin'. | ||
| * In the configuration form of a website there is a category logo. |
There was a problem hiding this comment.
s/category logo/"Logo" group
| Usage | ||
| ===== | ||
|
|
||
| This addon supports multi-website. If no logo is defined a transparent image is |
There was a problem hiding this comment.
Not really mandatory in English and it would kind of hinder the reading of the whole phrase...
There was a problem hiding this comment.
Yes, it's mandatory in English (http://www.shertonenglish.com/resources/es/conditionals/type0.php)
There was a problem hiding this comment.
Native English speaker - can confirm, comma required
There was a problem hiding this comment.
Ok, I had the rule wrong on my mind (comma is not needed when the clause comes before the condition). Anyway, doesn't it feel like the sentence has more commas than needed? 😃
| 'category': 'Website', | ||
| 'author': "Agile Business Group,Odoo Community Association (OCA)", | ||
| 'author': "Agile Business Group, " | ||
| "Antiun Ingeniería S.L., " |
b59993d to
f9a9c56
Compare
|
@pedrobaeza changes done and squashed |
|
Thanks @chienandalu Then, 👍 |
|
@eLBati that is because the GitHub user doesn't have that email address linked to its account. |
|
@pedrobaeza so he needs to configure the github account, to fix ae19202 , right? |
|
Exactly |
|
Hi, I added stephan@west.nl to my account. |
|
@StephanRozendaal thanks |
|
Looks good @chienandalu, thanks! Can you please squash f9a9c56 & 7dfd73c FYI Travis was failing on one, but I'm pretty sure it was a timeout. Re-running it |
7dfd73c to
4fc620b
Compare
|
Thanks, @lasley 😄 |
Website logo
Load a logo image to be used on website only. This allows to use an internal
company logo (for reports) and a different website logo.
cc @Tecnativa