[MIG][website_crm_privacy_policy] Migrate to v10 - #359
Merged
Merged
Conversation
Member
|
Can you rebase to see if sample pages work? |
chienandalu
reviewed
Jul 6, 2017
| class="o_website_form_input" | ||
| required="required"/> | ||
| <label class="control-label"> | ||
| <t t-call="website_legal_page.acceptance_full"/> |
Member
There was a problem hiding this comment.
The default links given here aren't valid. For example: /page/terms where the default terms page is on /legal/terms-of-use
… test fails on this dead link.
New `website_form` addon includes an undocumented validation system. By simply adapting layout to what it wants, we get validation for free.
yajo
force-pushed
the
10.0-website_crm_privacy_policy
branch
from
July 7, 2017 07:53
76667bf to
ba80b5c
Compare
Member
Author
|
Rebased, should work now |
chienandalu
approved these changes
Jul 7, 2017
chienandalu
left a comment
Member
There was a problem hiding this comment.
Perfect. Now it works 🙂 👍
pedrobaeza
approved these changes
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very simple migration.
@Tecnativa