[MIG][website_snippet_marginless_gallery] Migrate to v9 - #368
Merged
pedrobaeza merged 5 commits intoAug 30, 2017
Merged
Conversation
pedrobaeza
requested changes
Jul 25, 2017
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Tests are broken and I can't try on runbot due to compass installation
| "name": "Marginless Gallery Snippet", | ||
| "summary": "Add a snippet to have a marginless image gallery", | ||
| "version": "8.0.1.0.1", | ||
| "version": "9.0.1.0.1", |
| # -*- coding: utf-8 -*- | ||
| # © 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. - Jairo Llopis | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
| # Copyright 2015-today Jairo Llopis <jairo.llopis@tecnativa.com> |
Member
Author
There was a problem hiding this comment.
I got inspired by react/react@bef45b0 and the assumption that Facebook has good lawyers.
Member
There was a problem hiding this comment.
We don't use this rule in OCA (which is abusing), so change it
Member
|
I still can't try on runbot. |
pedrobaeza
force-pushed
the
9.0-website_snippet_marginless_gallery
branch
from
August 26, 2017 11:59
e77b717 to
8e50e1b
Compare
Member
|
I have been trying on runbot but I'm not able to change the background image of any tile, as "Customize" doesn't appear when selecting a tile. |
Member
Author
|
I guess it should be fixed now, let's try when runbot builds. |
Member
|
@yajo, I'm still not able to customize tile background image. |
pedrobaeza
approved these changes
Aug 28, 2017
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Now is finally working.
@rafaelbn please review
Update roadmap.
Credit creators, using same name across modules to avoid split statistics. Ensure images get displayed if content is removed.
- Relicense to LGPL. - Move tour to demo asset. - Remove precompiled CSS. - Update snippet options JS API. - Update tour's API and definition.
yajo
force-pushed
the
9.0-website_snippet_marginless_gallery
branch
from
August 30, 2017 07:41
6c1ae82 to
13d7702
Compare
Member
Author
|
Squashed for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa