11.0 mig website legal page by nadiaafa · Pull Request #403 · OCA/website

nadiaafa · 2017-12-21T09:40:07Z

No description provided.

njeudy · 2018-01-12T21:30:29Z

@nadiaafa can you squash transbot commit ?

njeudy · 2018-01-12T21:31:03Z

+                                                </t>
+                                            </p>
+                                            <div>
+                                                <t t-if="res_company.phone or res_company.email or res_company.fax">


res_company.fax does not exist anymore

njeudy · 2018-01-12T21:31:26Z

+                                        </t>
+                                    </div>
+                                    <div>
+                                        <t t-if="res_company.phone or res_company.email or res_company.fax">


res_company.fax does not exists anymore

njeudy · 2018-01-13T13:50:52Z

@nadiaafa can you add me to your merge request branch ? I can make changes if needed .

nadiaafa · 2018-01-13T14:39:36Z

thank you @njeudy i added you 👍

njeudy · 2018-01-13T15:07:21Z

I clean history and keep you as author of last commit :) wait for ci :)

nadiaafa · 2018-01-13T20:36:04Z

Merci @njeudy

njeudy · 2018-01-14T19:32:41Z

@nadiaafa should look to test failed .. will work on it tomorrow.

njeudy · 2018-01-18T20:38:11Z

Think odoo 11 return 200 and not 404 when page does not existe, because

"GET http://legal/no-page HTTP/1.1" 200 -

Because odoo propose to create un new page

Will change test function to reflect this ..

oca-clabot · 2018-01-18T20:41:42Z

Hey @nadiaafa, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Nadia AFAKROUCH (no github login found)
zeroheure (no github login found)
Nicola Malcontenti (no github login found)

Appreciation of efforts,
OCA CLAbot

njeudy · 2018-01-21T20:20:57Z

@pedrobaeza @lasley should we correct lint error that is on an other module ?

lasley · 2018-01-22T16:34:55Z

@njeudy - nah just the lints in this module will be fine. Not sure why the others are failing - AFAIK they're only supposed to trigger on changed modules.

simahawk · 2018-01-22T16:48:59Z

+
+This module was written to provide common legal pages needed in any website:
+
+* **Legal advice**: Website propietary and disclaimers


*proprietary

simahawk · 2018-01-22T16:50:48Z

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-


remove coding headers from all py files

simahawk · 2018-01-22T16:51:21Z

+              'LasLabs, '
+              'Nicolas JEUDY, '
+              'Odoo Community Association (OCA)',
+    'website': 'https://www.tecnativa.com',


https://github.com/OCA/website

simahawk · 2018-01-22T16:52:28Z

+        response = self.url_open(page, timeout=20)
+        self.assertEqual(response.status_code, code)
+
+    # TODO: comment this test because odoo 11 return 200 even if page does not exist..


Whaaat? Seriously? 😄

damn, is true...
Odoo 11:

Odoo 10:

I filed a bug odoo/odoo#22438

Instead of this, you should:

# HACK https://github.com/odoo/odoo/issues/22438 # TODO Remove when fixed @unittest.expectedFailure #[and here the test, uncommented]

@njeudy it's fixed. Would you mind dropping the hack? :)

- Fix review comments - Icon changed - Bug tracker added - [IMP] README and OCA as author

Many submodules from this one need the template I'm adding. Having it here allows for better reusability and avoids duplicated translation efforts.

OCA Transbot updated translations from Transifex

* Move legal pages to explicit /legal routes Fixes by PR review Fix my obvious lack of testing

- Update copyright headers. - Update copyright holders data. - Remove .pot file. - Add migration script.

* [ADD][website_multi_theme] Allow different themes by website This a somewhat hacky addon that adds support for setting a different theme by website. Always updates views arch in development and demo instances. This allows faster development, while keeping stability and no surprises in production. * fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * squash! fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found Fix tests that were getting warnings logged and random timeouts.

njeudy · 2018-01-23T20:08:32Z

@simahawk i can't have ci ok because ok website_multi_theme module .. and I think it depends of odoo module .. should I try to correct this ?

simahawk · 2018-01-24T09:23:45Z

@njeudy travis is red because of linting. You should fix that. Runbot is actually yellow for a warning but it should have been fixed in OCB and MQT.

yajo

Fix the linter please

yajo · 2018-01-24T10:34:01Z

+        response = self.url_open(page, timeout=20)
+        self.assertEqual(response.status_code, code)
+
+    # TODO: comment this test because odoo 11 return 200 even if page does not exist..


Instead of this, you should:

# HACK https://github.com/odoo/odoo/issues/22438 # TODO Remove when fixed @unittest.expectedFailure #[and here the test, uncommented]

njeudy · 2018-01-24T14:33:59Z

@yajo @simahawk : the linter is on an other already merge module .. I should correct in this merge request ?

************* Module website_multi_theme
website_multi_theme/__init__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
website_multi_theme/static/src/js/theme.js:15: [W7903(javascript-lint), ] 'reload' is defined but never used. [Error/no-unused-vars]
************* Module website_multi_theme.__manifest__
website_multi_theme/__manifest__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.models.__init__
website_multi_theme/models/__init__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.models.ir_qweb
website_multi_theme/models/ir_qweb.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.models.ir_ui_view
website_multi_theme/models/ir_ui_view.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.models.website
website_multi_theme/models/website.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.models.website_theme
website_multi_theme/models/website_theme.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.tests.__init__
website_multi_theme/tests/__init__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.tests.test_assets
website_multi_theme/tests/test_assets.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.wizards.__init__
website_multi_theme/wizards/__init__.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary
************* Module website_multi_theme.wizards.website_config_settings
website_multi_theme/wizards/website_config_settings.py:1: [C8202(unnecessary-utf8-coding-comment), ] UTF-8 coding is not necessary

njeudy · 2018-01-24T20:16:40Z

@simahawk @yajo ok done !!

njeudy · 2018-01-25T18:52:03Z

@yajo ok for you ? linter is green :)

pedrobaeza added this to the 11.0 milestone Dec 21, 2017

pedrobaeza added the needs review label Dec 21, 2017

pedrobaeza mentioned this pull request Dec 21, 2017

Migration to version 11.0 #388

Closed

38 tasks

njeudy mentioned this pull request Jan 12, 2018

[MIG] website_cookie_notice: Migrated to 11.0 #408

Merged

1 task

njeudy suggested changes Jan 12, 2018

View reviewed changes

njeudy force-pushed the 11.0-mig-website_legal_page branch 2 times, most recently from ffe0f58 to 2f9e7ae Compare January 13, 2018 15:02

njeudy force-pushed the 11.0-mig-website_legal_page branch from 2f9e7ae to fccd802 Compare January 18, 2018 20:41

njeudy force-pushed the 11.0-mig-website_legal_page branch from fccd802 to 592910b Compare January 19, 2018 07:34

simahawk requested changes Jan 22, 2018

View reviewed changes

Antonio Espinosa and others added 10 commits January 23, 2018 16:15

[ADD] website_legal_page addon

645bc1e

- Fix review comments - Icon changed - Bug tracker added - [IMP] README and OCA as author

[FIX] Space at the end of a traslation line

0ca2520

[FIX] mailto links in default legal pages is malformed

0b60c1a

OCA Transbot updated translations from Transifex

98d4711

[UPD] prefix versions with 8.0

4345be0

[MIG] Make modules uninstallable

797b82e

[8.0][IMP][website_legal_page] Reusable templates for legal terms

c56b7d0

Many submodules from this one need the template I'm adding. Having it here allows for better reusability and avoids duplicated translation efforts.

Seems like I can only set page to True, so I won't set it.

8ec4654

Upgrade website_legal_page to 9.0

41b7600

Add missing translations for website_legal_page

1055d21

pedrobaeza and others added 13 commits January 23, 2018 16:15

[IMP] website_legal_page: Credits to authors

ae0a877

OCA Transbot updated translations from Transifex

de057f3

[FIX] remove en.po that was erroneously created by transbot

1101d41

[MIG] Make modules uninstallable

7aa2a3d

[MIG] Rename manifest files

8fe6cd4

OCA Transbot updated translations from Transifex

37ffa6f

OCA Transbot updated translations from Transifex

[MIG] website_legal_page: Migrated to 10.0

2878330

[IMP] website_legal: Move to explicit route

c02e3e9

* Move legal pages to explicit /legal routes Fixes by PR review Fix my obvious lack of testing

[MIG][website_legal_page] Migration script and polish

c17e51e

- Update copyright headers. - Update copyright holders data. - Remove .pot file. - Add migration script.

OCA Transbot updated translations from Transifex

67e4d24

[FIX][website_legal_page] Fix links in reusable template

8d20dad

[FIX] website_legal_page: add missing space before caret (OCA#391)

6a2d7b5

njeudy force-pushed the 11.0-mig-website_legal_page branch from 592910b to b213685 Compare January 23, 2018 15:16

[MIG] website_legal_page : Migration to 11.0

970fd8f

njeudy force-pushed the 11.0-mig-website_legal_page branch from b213685 to 970fd8f Compare January 23, 2018 15:35

yajo requested changes Jan 24, 2018

View reviewed changes

Nicolas JEUDY added 2 commits January 24, 2018 15:45

[WARN] failure expected on test due to odoo framework bug

85225ce

[FIX] Linter on website_multi_theme py file

008a90a

njeudy force-pushed the 11.0-mig-website_legal_page branch from a3f0c94 to 008a90a Compare January 24, 2018 20:08

simahawk approved these changes Jan 25, 2018

View reviewed changes

yajo approved these changes Jan 26, 2018

View reviewed changes

yajo merged commit 14d60ab into OCA:11.0 Jan 26, 2018


		This module was written to provide common legal pages needed in any website:

		* Legal advice: Website propietary and disclaimers

Uh oh!

Conversation

nadiaafa commented Dec 21, 2017

Uh oh!

njeudy commented Jan 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

njeudy commented Jan 13, 2018

Uh oh!

nadiaafa commented Jan 13, 2018

Uh oh!

njeudy commented Jan 13, 2018

Uh oh!

nadiaafa commented Jan 13, 2018

Uh oh!

njeudy commented Jan 14, 2018

Uh oh!

njeudy commented Jan 18, 2018

Uh oh!

oca-clabot commented Jan 18, 2018

Uh oh!

njeudy commented Jan 21, 2018

Uh oh!

lasley commented Jan 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

njeudy commented Jan 23, 2018

Uh oh!

simahawk commented Jan 24, 2018

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

njeudy commented Jan 24, 2018

Uh oh!

njeudy commented Jan 24, 2018

Uh oh!

njeudy commented Jan 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants