[11.0][MIG] website_analytics_piwik - #404
Merged
Merged
Conversation
|
I'd squash translation commits all in one and - if time allows - prefix some commits (like "fix coding style" and such) w/ the module name 😉 |
hmrodrigues
reviewed
Dec 26, 2017
| @@ -1,4 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
Member
There was a problem hiding this comment.
Why have you removed the encoding?
Member
Author
There was a problem hiding this comment.
Because utf-8 is default encoding for Python 3
hmrodrigues
approved these changes
Dec 29, 2017
Member
Author
|
Translation commits squashed together |
Member
Author
|
Can we merge this one? |
yung-wang
approved these changes
Jan 15, 2018
hbrunn
requested changes
Jan 15, 2018
hbrunn
left a comment
Member
There was a problem hiding this comment.
could you add a migration script that sets the flag for existing installations which have an ID set?
Member
Author
|
@hbrunn Done! |
Member
Author
|
Squashed |
hbrunn
approved these changes
Jan 15, 2018
Member
|
Merging |
Member
|
so I kept this tab open so wait for runbot come back positive... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting of module website_analytics_piwik to V11