Skip to content

[11.0] migrate website_odoo_debranding - #428

Merged
pedrobaeza merged 4 commits into
OCA:11.0from
ddufresne:11.0-mig-website_odoo_debranding
Feb 28, 2018
Merged

pedrobaeza merged 4 commits into
OCA:11.0from
ddufresne:11.0-mig-website_odoo_debranding

Conversation

@ddufresne

Copy link
Copy Markdown
Contributor

No description provided.

cubells and others added 3 commits February 26, 2018 22:09
* Imported last updates from v8
* Adapted to v9
* Renamed to website_odoo_debranding
* Updated README
- Relicensed to LGPL.
- The template that does the job can be disabled by the admin.
@ddufresne ddufresne mentioned this pull request Feb 27, 2018
38 tasks

@simahawk simahawk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small glitches

Comment thread website_odoo_debranding/__init__.py Outdated
@@ -0,0 +1,2 @@
# -*- coding: utf-8 -*-

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove encoding from *.py

Comment thread website_odoo_debranding/__manifest__.py Outdated
"version": "11.0.1.0.0",
"author": "Tecnativa, "
"Odoo Community Association (OCA)",
"website": "https://www.tecnativa.com",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread website_odoo_debranding/README.rst Outdated
@@ -0,0 +1,62 @@
.. image:: https://img.shields.io/badge/licence-LGPL--3-blue.svg

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svg -> png (as svg is not supported in apps and images are not rendered)

@pedrobaeza

Copy link
Copy Markdown
Member

Check also existing warning:

2018-02-27 03:57:30,971 166 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view Remove Odoo Promotional Link (): use the hasclass(*classes) function to filter elements by their classes
2018-02-27 03:57:31,054 166 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view Remove Odoo Promotional Link (website_odoo_debranding.layout_footer_copyright): use the hasclass(*classes) function to filter elements by their classes

@pedrobaeza pedrobaeza added this to the 11.0 milestone Feb 27, 2018
@ddufresne

Copy link
Copy Markdown
Contributor Author

@simahawk fixed

@simahawk

Copy link
Copy Markdown

@ddufresne sounds good. One last thing: squash your commits and reword to [MIG][11.0] website_odoo_debranding or similar. Tnx.

@rgarnau rgarnau left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ddufresne
ddufresne force-pushed the 11.0-mig-website_odoo_debranding branch from 32ec17f to 05ef9b9 Compare February 28, 2018 14:22
@ddufresne

Copy link
Copy Markdown
Contributor Author

@simahawk @rgarnau @pedrobaeza thanks for the review. sqash done

@pedrobaeza
pedrobaeza merged commit 973c39b into OCA:11.0 Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants